Skip to content

Commit 9cd0f81

Browse files
authored
Merge pull request ceph#56438 from tchaikov/wip-test-unittest-mem-fix-leak
test/common: do not leak in MemoryIsZeroSmallTest Reviewed-by: Rongqi Sun <[email protected]>
2 parents bc2aba4 + 4deebd6 commit 9cd0f81

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/test/common/test_memory.cc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,11 +30,11 @@ TEST_P(MemoryIsZeroBigTest, MemoryIsZeroTestBig) {
3030
TEST_P(MemoryIsZeroSmallTest, MemoryIsZeroTestSmall) {
3131
size_t size = GetParam();
3232
for (size_t i = 0; i < size; i++) {
33-
char* data = new char[size]();
34-
EXPECT_TRUE(mem_is_zero(data, size));
33+
auto data = std::make_unique<char[]>(size);
34+
EXPECT_TRUE(mem_is_zero(data.get(), size));
3535

3636
data[i] = 'a';
37-
EXPECT_FALSE(mem_is_zero(data, size));
37+
EXPECT_FALSE(mem_is_zero(data.get(), size));
3838
}
3939
}
4040

0 commit comments

Comments
 (0)