Skip to content

Commit a3e7652

Browse files
authored
Merge pull request ceph#65559 from nbalacha/wip-nbalacha-cleanup-1
rgw/bucket-logging: minor code cleanup
2 parents d037f40 + 527b15d commit a3e7652

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

src/rgw/driver/rados/rgw_notify.cc

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ static inline std::ostream& operator<<(std::ostream& out,
5050

5151
struct persistency_tracker {
5252
ceph::coarse_real_time last_retry_time {ceph::coarse_real_clock::zero()};
53-
uint32_t retires_num {0};
53+
uint32_t retries_num {0};
5454
};
5555

5656
using queues_t = std::set<std::string>;
@@ -233,11 +233,11 @@ class Manager : public DoutPrefixProvider {
233233
const auto time_now = ceph::coarse_real_clock::now();
234234
if ( (topic_persistency_ttl != 0 && event_entry.creation_time != ceph::coarse_real_clock::zero() &&
235235
time_now - event_entry.creation_time > std::chrono::seconds(topic_persistency_ttl))
236-
|| ( topic_persistency_max_retries != 0 && entry_persistency_tracker.retires_num > topic_persistency_max_retries) ) {
236+
|| ( topic_persistency_max_retries != 0 && entry_persistency_tracker.retries_num > topic_persistency_max_retries) ) {
237237
ldpp_dout(this, 1) << "WARNING: Expiring entry marker: " << entry.marker
238238
<< " for event with " << event_entry
239239
<< " entry retry_number: "
240-
<< entry_persistency_tracker.retires_num
240+
<< entry_persistency_tracker.retries_num
241241
<< " creation_time: " << event_entry.creation_time
242242
<< " time_now: " << time_now << dendl;
243243
return EntryProcessingResult::Expired;
@@ -246,11 +246,11 @@ class Manager : public DoutPrefixProvider {
246246
return EntryProcessingResult::Sleeping;
247247
}
248248

249-
++entry_persistency_tracker.retires_num;
249+
++entry_persistency_tracker.retries_num;
250250
entry_persistency_tracker.last_retry_time = time_now;
251251
ldpp_dout(this, 20) << "Processing event entry with " << event_entry
252252
<< " retry_number: "
253-
<< entry_persistency_tracker.retires_num
253+
<< entry_persistency_tracker.retries_num
254254
<< " current time: " << time_now << dendl;
255255
ret = push_endpoint->send(this, event_entry.event, yield);
256256
if (ret < 0) {

src/rgw/rgw_appmain.cc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,8 @@ int rgw::AppMain::init_storage()
255255
run_quota,
256256
run_sync,
257257
g_conf().get_val<bool>("rgw_dynamic_resharding"),
258-
true, true, null_yield, env.cfgstore, // run notification thread
258+
true, // run notification thread
259+
true, null_yield, env.cfgstore,
259260
g_conf()->rgw_cache_enabled);
260261
if (!env.driver) {
261262
return -EIO;

0 commit comments

Comments
 (0)