Skip to content

Commit a581a38

Browse files
authored
Merge pull request ceph#54158 from michaelalang/master
[cephadm](BUG): honor --skip-firewalld in section Open ports explicitly required for the daemon Reviewed-by: Adam King <[email protected]>
2 parents 5eca12b + fca3a61 commit a581a38

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

src/cephadm/cephadm.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2945,10 +2945,11 @@ def deploy_daemon(
29452945
update_firewalld(ctx, daemon_form_create(ctx, ident))
29462946

29472947
# Open ports explicitly required for the daemon
2948-
if endpoints:
2949-
fw = Firewalld(ctx)
2950-
fw.open_ports([e.port for e in endpoints] + fw.external_ports.get(daemon_type, []))
2951-
fw.apply_rules()
2948+
if not ('skip_firewalld' in ctx and ctx.skip_firewalld):
2949+
if endpoints:
2950+
fw = Firewalld(ctx)
2951+
fw.open_ports([e.port for e in endpoints] + fw.external_ports.get(daemon_type, []))
2952+
fw.apply_rules()
29522953

29532954
# If this was a reconfig and the daemon is not a Ceph daemon, restart it
29542955
# so it can pick up potential changes to its configuration files

0 commit comments

Comments
 (0)