Skip to content

Commit a6b95a5

Browse files
qa/cephfs: update a test in test_volumes.py
Test name is test_subvolume_snapshot_info_if_clone_pending_for_no_group, located in class TestSubvolumeSnapshotClones in test_volumes.py 5 seconds can (sometimes) be insufficient as value of the config option "snapshot_clone_delay" in this. Increase it to avoid unnecessary race conditions which leads to irrelevant failures. Following is an example where 5 seconds was insufficient as waiting period since instead it took 8 seconds - 2024-07-28T18:16:10.088 DEBUG:teuthology.orchestra.run.smithi064:> sudo adjust-ulimits ceph-coverage /home/ubuntu/cephtest/archive/coverage timeout 120 ceph --cluster ceph config set mgr mgr/volumes/snapshot_clone_no_wait False ... 2024-07-28T18:16:18.694 DEBUG:teuthology.orchestra.run.smithi064:> sudo adjust-ulimits ceph-coverage /home/ubuntu/cephtest/archive/coverage timeout 120 ceph --cluster ceph fs subvolume snapshot info cephfs subvol79370 subvol_snap40980 This issue was seen during testing of PR to which this commit belongs. This commit has been separated from the commit that adds tests for clone progress reporting so that it's easy to document need for this code patch and also track it. This commit is not being moved to a different PR and been kept on the same PR since it can't be reproduced otherwise. This also ensures that commit is backported to older release along with code that caused this issue, causing no one to need to find this commit while backporting effort. Signed-off-by: Rishabh Dave <[email protected]>
1 parent 645cc6e commit a6b95a5

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

qa/tasks/cephfs/test_volumes.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5845,7 +5845,7 @@ def test_subvolume_snapshot_info_if_clone_pending_for_no_group(self):
58455845
self._fs_cmd("subvolume", "snapshot", "create", self.volname, subvolume, snapshot)
58465846

58475847
# insert delay at the beginning of snapshot clone
5848-
self.config_set('mgr', 'mgr/volumes/snapshot_clone_delay', 5)
5848+
self.config_set('mgr', 'mgr/volumes/snapshot_clone_delay', 15)
58495849

58505850
# disable "capped" clones
58515851
self.config_set('mgr', 'mgr/volumes/snapshot_clone_no_wait', False)

0 commit comments

Comments
 (0)