Merge pull request ceph#60507 from synarete/ss-cephfs-asyncio-use-after-free-bugfix

client: fix memory leak in Client::CRF_iofinish::complete

Reviewed-by: Venky Shankar <[email protected]>
Reviewed-by: Dhairya Parmar <[email protected]>
Reviewed-by: Patrick Donnelly <[email protected]>

Author: vshankar

src/client/Client.h

@@ -1389,14 +1389,6 @@ class Client : public Dispatcher, public md_config_obs_t {
     void finish(int r) override {
       CRF->finish_io(r);
     }
-
-    // For _read_async, we may not finish in one go, so be prepared for multiple
-    // calls to complete. All the handling though is in C_Read_Finisher.
-    void complete(int r) override {
-      finish(r);
-      if (CRF->iofinished)
-        delete this;
-    }
   };
 
   class C_Read_Sync_NonBlocking : public Context {