Merge pull request ceph#61089 from pecastro/mgr_proto_build_generation

pybind/mgr: Protobuffer file generation for grpc deps.

Reviewed-by: baum <NOT@FOUND>
Reviewed-by: ceph-jenkins <NOT@FOUND>
Reviewed-by: Ernesto Puerta <[email protected]>
Reviewed-by: Nizamudeen A <[email protected]>

Author: nizamial09

.gitignore

@@ -97,3 +97,8 @@ src/pybind/rbd/rbd.egg-info/
 src/pybind/rgw/build/
 src/pybind/rgw/rgw.c
 src/pybind/rgw/rgw.egg-info/
+
+# GRPC protobuff file generation #PR 61089
+src/pybind/mgr/dashboard/services/proto/gateway.proto
+src/pybind/mgr/dashboard/services/proto/gateway_pb2.py
+src/pybind/mgr/dashboard/services/proto/gateway_pb2_grpc.py

src/nvmeof/gateway

@@ -1,3 +1,32 @@
+# Required for building the dashboard grpc protos at build time
+set(CEPH_GRPC_VIRTUALENV ${CEPH_BUILD_VIRTUALENV}/ceph-grpc-virtualenv)
+set(CEPH_NVME_GATEWAY_PROTO_DIR ${CMAKE_CURRENT_SOURCE_DIR}/../../../../src/nvmeof/gateway/control/proto)
+
+add_custom_command(
+  OUTPUT ${CEPH_GRPC_VIRTUALENV}/lib/python*/site-packages/grpc_tools
+  COMMAND ${CMAKE_SOURCE_DIR}/src/tools/setup-virtualenv.sh --python=${Python3_EXECUTABLE} ${CEPH_GRPC_VIRTUALENV}
+  COMMAND ${CEPH_GRPC_VIRTUALENV}/bin/pip install grpcio-tools
+  WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
+  COMMENT "grpcio-tools is being installed")
+
+# protobuffer files generation
+add_custom_command(
+  OUTPUT "${CMAKE_CURRENT_SOURCE_DIR}/services/proto/gateway_pb2.py" "${CMAKE_CURRENT_SOURCE_DIR}/services/proto/gateway_pb2_grpc.py"
+  COMMAND cp ${CEPH_NVME_GATEWAY_PROTO_DIR}/gateway.proto dashboard/services/proto/gateway.proto
+  COMMAND . ${CEPH_GRPC_VIRTUALENV}/bin/activate && ${CEPH_GRPC_VIRTUALENV}/bin/python -m grpc_tools.protoc --proto_path=. --python_out=. --grpc_python_out=. dashboard/services/proto/gateway.proto && deactivate
+  WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/..
+  DEPENDS ${CEPH_NVME_GATEWAY_PROTO_DIR}/gateway.proto ${CEPH_GRPC_VIRTUALENV}/lib/python*/site-packages/grpc_tools
+  COMMENT "proto generation for grpc deps")
+add_custom_target(mgr-dashboard-services-deps
+  DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/services/proto/gateway_pb2.py ${CMAKE_CURRENT_SOURCE_DIR}/services/proto/gateway_pb2_grpc.py
+  WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR})
+
+add_custom_target(mgr-dashboard-services-build
+  ALL
+  DEPENDS mgr-dashboard-services-deps)
+
+add_dependencies(tests mgr-dashboard-services-build)
+
 install(DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
   DESTINATION ${CEPH_INSTALL_DATADIR}/mgr
   ${mgr_module_install_excludes}
@@ -14,6 +43,7 @@ if(WITH_MGR_DASHBOARD_FRONTEND)
     add_tox_test(mgr-dashboard-check TOX_ENVS check)
     add_tox_test(mgr-dashboard-openapi TOX_ENVS openapi-check)
   endif()
+
 else()
   if(EXISTS ${CMAKE_CURRENT_SOURCE_DIR}/frontend/dist)
     # prebuilt

src/pybind/mgr/dashboard/CMakeLists.txt

@@ -11,5 +11,5 @@ pyyaml
 natsort
 setuptools
 jsonpatch
-grpcio==1.46.5
-grpcio-tools==1.46.5
+grpcio
+grpcio-tools