crimson/osd/replicated_backend: make sure the check on whether to send

xxhdx1985126 · Matan-B · commit af1bc2220f6d · 2025-01-05T16:22:12.000Z
ops to replica osds and the pg log append happens in the same
continuation

Since backfill relies on the pg log to discover new modifications, we
need to make sure backfill always discover the modification that's not
sent to replica osds.

Signed-off-by: Xuehan Xu &lt;xuxuehan@qianxin.com&gt;
diff --git a/src/crimson/osd/replicated_backend.cc b/src/crimson/osd/replicated_backend.cc
@@ -104,6 +104,8 @@ ReplicatedBackend::submit_transaction(
     }
   }
 
+  co_await pg.update_snap_map(log_entries, txn);
+
   std::vector<pg_shard_t> to_push_clone;
   std::vector<pg_shard_t> to_push_delete;
   auto sends = std::make_unique<std::vector<seastar::future<>>>();
@@ -140,8 +142,6 @@ ReplicatedBackend::submit_transaction(
 	pg_shard.osd, std::move(m), map_epoch));
   }
 
-  co_await pg.update_snap_map(log_entries, txn);
-
   pg.log_operation(
     std::move(log_entries),
     osd_op_p.pg_trim_to,

Original file line number	Diff line number	Diff line change
`@@ -104,6 +104,8 @@ ReplicatedBackend::submit_transaction(`
`104`	`104`	`}`
`105`	`105`	`}`
`106`	`106`
	`107`	`+ co_await pg.update_snap_map(log_entries, txn);`
	`108`	`+`
`107`	`109`	`std::vector<pg_shard_t> to_push_clone;`
`108`	`110`	`std::vector<pg_shard_t> to_push_delete;`
`109`	`111`	`auto sends = std::make_unique<std::vector<seastar::future<>>>();`
`@@ -140,8 +142,6 @@ ReplicatedBackend::submit_transaction(`
`140`	`142`	`pg_shard.osd, std::move(m), map_epoch));`
`141`	`143`	`}`
`142`	`144`
`143`		`- co_await pg.update_snap_map(log_entries, txn);`
`144`		`-`
`145`	`145`	`pg.log_operation(`
`146`	`146`	`std::move(log_entries),`
`147`	`147`	`osd_op_p.pg_trim_to,`