Skip to content

Commit b7d0770

Browse files
qa/cephfs: block buggy tests in test_admin.py
Block test_idem_unaffected_root_squash temporarily and test_multifs_single_path_rootsquash. This test fails due to a known bug. Block it temporarily so that test_admin.py can run fully and PRs under QA can be tested fully. Otherwise, this test fails and that halts test_admin.py, which leaves the PR partially untested. This failure is then seen as an unrelated failure which lets the buggy code get merged. This has happened recently. Signed-off-by: Rishabh Dave <[email protected]>
1 parent c2fb936 commit b7d0770

File tree

1 file changed

+12
-0
lines changed

1 file changed

+12
-0
lines changed

qa/tasks/cephfs/test_admin.py

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -839,6 +839,9 @@ def test_fs_rename_fails_for_non_existent_fs(self):
839839
"""
840840
That renaming a non-existent file system fails.
841841
"""
842+
self.skipTest('This test is broken ATM; see '
843+
'https://tracker.ceph.com/issues/66088')
844+
842845
self.run_ceph_cmd(f'fs fail {self.fs.name}')
843846
self.run_ceph_cmd(f'fs set {self.fs.name} refuse_client_session true')
844847
sleep(5)
@@ -1444,6 +1447,9 @@ def test_multifs_single_path_rootsquash(self):
14441447
"""
14451448
Test root_squash with multi fs
14461449
"""
1450+
self.skipTest('this test is broken ATM, see: '
1451+
'https://tracker.ceph.com/issues/66076.')
1452+
14471453
self.fs1 = self.fs
14481454
self.fs2 = self.mds_cluster.newfs('testcephfs2')
14491455
self.mount_b.remount(cephfs_name=self.fs2.name)
@@ -1604,6 +1610,9 @@ def test_single_path_authorize_on_nonalphanumeric_fsname(self):
16041610
That fs authorize command works on filesystems with names having [_.-]
16051611
characters
16061612
"""
1613+
self.skipTest('this test is broken ATM, see: '
1614+
'https://tracker.ceph.com/issues/66077')
1615+
16071616
self.mount_a.umount_wait(require_clean=True)
16081617
self.mds_cluster.delete_all_filesystems()
16091618
fs_name = "cephfs-_."
@@ -1948,6 +1957,9 @@ def test_idem_unaffected_root_squash(self):
19481957
caps mon = "allow r fsname=a"
19491958
caps osd = "allow rw tag cephfs data=a"
19501959
"""
1960+
self.skipTest('this test is broken ATM, see '
1961+
'https://tracker.ceph.com/issues/65808')
1962+
19511963
PERM, PATH = 'rw', 'dir1'
19521964
self.mount_a.run_shell(f'mkdir {PATH}')
19531965
self.captester = CapTester(self.mount_a, PATH)

0 commit comments

Comments
 (0)