Skip to content

Commit b891223

Browse files
committed
debian,ceph.spec: add ceph-osd-crimson as dependency
a37b5b5 added ceph-osd-crimson as dependency using OR requirement. Once ceph-osd-classic dependency is satisfied, ceph-osd-crimson package must be added manually. In order to not add crimson packages manually (See "Containerfile" removed lines) - mark osd-crimson as dependency if with_crimson is enabled for rpm and if pkg.ceph.crimson build profile is enabled for debian. With this change, users won't be required to obtain ceph-osd-crimson package manually when relevant. Similarly to ceph-osd-classic being a dependency for ceph-osd. Signed-off-by: Matan Breizman <[email protected]>
1 parent e194cca commit b891223

File tree

3 files changed

+6
-7
lines changed

3 files changed

+6
-7
lines changed

ceph.spec.in

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -912,7 +912,10 @@ Summary: Ceph Object Storage Daemon
912912
Group: System/Filesystems
913913
%endif
914914
Requires: ceph-base = %{_epoch_prefix}%{version}-%{release}
915-
Requires: (ceph-osd-classic = %{_epoch_prefix}%{version}-%{release} or ceph-osd-crimson = %{_epoch_prefix}%{version}-%{release})
915+
Requires: ceph-osd-classic = %{_epoch_prefix}%{version}-%{release}
916+
%if 0%{with crimson}
917+
Requires: ceph-osd-crimson = %{_epoch_prefix}%{version}-%{release}
918+
%endif
916919
Requires: sudo
917920
Requires: libstoragemgmt
918921
%if 0%{?weak_deps}

container/Containerfile

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -150,11 +150,6 @@ libradosstriper1 \
150150
rbd-mirror" \
151151
>> packages.txt
152152

153-
# Optional crimson package(s)
154-
RUN if [[ "${OSD_FLAVOR}" == "crimson-debug" || "${OSD_FLAVOR}" == "crimson-release" ]]; then \
155-
echo "ceph-osd-crimson" >> packages.txt ; \
156-
fi
157-
158153
# Ceph "Recommends"
159154
RUN echo "nvme-cli python3-saml smartmontools" >> packages.txt
160155
# NFS-Ganesha

debian/control

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -416,7 +416,8 @@ Description: debugging symbols for ceph-mon
416416

417417
Package: ceph-osd
418418
Architecture: linux-any
419-
Depends: ceph-osd-classic (= ${binary:Version}) | ceph-osd-crimson (= ${binary:Version}),
419+
Depends: ceph-osd-classic (= ${binary:Version}),
420+
ceph-osd-crimson (= ${binary:Version}) <pkg.ceph.crimson>,
420421
sudo,
421422
${python3:Depends},
422423
${misc:Depends},

0 commit comments

Comments
 (0)