Skip to content

Commit b929fd0

Browse files
committed
test/osd: Disallow using testrecovery and parallel at the same time in ceph_test_rados_io_sequence
Due to --testrecovery needing to take OSDs offline in some tests, it is not compatible with the --parallel option, so it is now configured to return an error to the user in this case. Signed-off-by: Jon Bailey <[email protected]>
1 parent df966b2 commit b929fd0

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

src/test/osd/ceph_test_rados_io_sequence/ceph_test_rados_io_sequence.cc

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1122,6 +1122,11 @@ ceph::io_sequence::tester::TestRunner::TestRunner(
11221122
allow_pool_scrubbing = vm.contains("allow_pool_scrubbing");
11231123
disable_pool_ec_optimizations = vm.contains("disable_pool_ec_optimizations");
11241124

1125+
if (testrecovery && (num_objects > 1)) {
1126+
throw std::invalid_argument("testrecovery option not allowed if parallel is"
1127+
" specified, except when parallel=1 is used");
1128+
}
1129+
11251130
if (!dryrun) {
11261131
guard.emplace(boost::asio::make_work_guard(asio));
11271132
thread = make_named_thread("io_thread", [&asio = asio] { asio.run(); });

0 commit comments

Comments
 (0)