Skip to content

Commit bb93aa3

Browse files
committed
rgw/datalog: Stick noexcept on wrappers returning int
Easier to debug. Signed-off-by: Adam C. Emerson <[email protected]>
1 parent 4732944 commit bb93aa3

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/rgw/driver/rados/rgw_datalog.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -439,7 +439,7 @@ void DataLogBackends::handle_empty_to(uint64_t new_tail) {
439439
int RGWDataChangesLog::start(const DoutPrefixProvider *dpp,
440440
const RGWZone* zone,
441441
const RGWZoneParams& zoneparams,
442-
bool background_tasks)
442+
bool background_tasks) noexcept
443443
{
444444
log_data = zone->log_data;
445445
try {
@@ -1011,7 +1011,7 @@ void RGWDataChangesLog::add_entry(const DoutPrefixProvider* dpp,
10111011
int RGWDataChangesLog::add_entry(const DoutPrefixProvider* dpp,
10121012
const RGWBucketInfo& bucket_info,
10131013
const rgw::bucket_log_layout_generation& gen,
1014-
int shard_id, optional_yield y)
1014+
int shard_id, optional_yield y) noexcept
10151015
{
10161016
try {
10171017
if (y) {

src/rgw/driver/rados/rgw_datalog.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -449,7 +449,7 @@ class RGWDataChangesLog {
449449
bool recovery, bool watch, bool renew);
450450

451451
int start(const DoutPrefixProvider *dpp, const RGWZone* _zone,
452-
const RGWZoneParams& zoneparams, bool background_tasks);
452+
const RGWZoneParams& zoneparams, bool background_tasks) noexcept;
453453
asio::awaitable<bool> establish_watch(const DoutPrefixProvider* dpp,
454454
std::string_view oid);
455455
asio::awaitable<void> process_notification(const DoutPrefixProvider* dpp,
@@ -467,7 +467,7 @@ class RGWDataChangesLog {
467467
int add_entry(const DoutPrefixProvider *dpp,
468468
const RGWBucketInfo& bucket_info,
469469
const rgw::bucket_log_layout_generation& gen,
470-
int shard_id, optional_yield y);
470+
int shard_id, optional_yield y) noexcept;
471471
int get_log_shard_id(rgw_bucket& bucket, int shard_id);
472472
asio::awaitable<std::tuple<std::vector<rgw_data_change_log_entry>,
473473
std::string, bool>>

0 commit comments

Comments
 (0)