Skip to content

Commit be9d904

Browse files
committed
crimson/common/errorator: add TODO
There are few TODOs around errorator code which might be worth looking into: https://tracker.ceph.com/issues/70875 Signed-off-by: Matan Breizman <[email protected]>
1 parent 3bbbf0c commit be9d904

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

src/crimson/common/errorator.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -409,6 +409,8 @@ class maybe_handle_error_t {
409409
// However, this shouldn't be a big issue for `errorator` as
410410
// ErrorVisitorT are already checked for exhaustiveness at compile-time.
411411
if (type_info == ErrorT::error_t::get_exception_ptr_type_info()) {
412+
413+
// TODO: add missing explanation
412414
if constexpr (std::is_assignable_v<decltype(result), return_t>) {
413415
result = std::invoke(std::forward<ErrorVisitorT>(errfunc),
414416
ErrorT::error_t::from_exception_ptr(std::move(ep)));

0 commit comments

Comments
 (0)