Skip to content

Commit c15e56e

Browse files
committed
crimson/os/alienstore: submit from the alien world concurrently
Signed-off-by: Yingxin Cheng <[email protected]>
1 parent 5a5ca59 commit c15e56e

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

src/crimson/os/alienstore/alien_log.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ CnLog::~CnLog() {
1717
}
1818

1919
void CnLog::_flush(EntryVector& q, bool crash) {
20+
// XXX: the waiting here will block the thread for an indeterministic peroid
2021
seastar::alien::submit_to(inst, shard, [&q] {
2122
for (auto& it : q) {
2223
crimson::get_logger(it.m_subsys).log(

src/crimson/os/alienstore/alien_store.cc

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,10 +57,11 @@ class OnCommit final: public Context
5757
}
5858

5959
void finish(int) final {
60-
return seastar::alien::submit_to(alien, cpuid, [this] {
61-
alien_done.set_value();
60+
std::ignore = seastar::alien::submit_to(alien, cpuid,
61+
[&_alien_done=this->alien_done] {
62+
_alien_done.set_value();
6263
return seastar::make_ready_future<>();
63-
}).wait();
64+
});
6465
}
6566
};
6667
}

0 commit comments

Comments
 (0)