Skip to content

Commit c163fc0

Browse files
committed
common/options/crimson.yaml.in: add hot_tier_generations minimum
See ExtentPlacementManager::init dynamic_max_rewrite_generation = hot_tier_generations - 1; ceph_assert(dynamic_max_rewrite_generation > MIN_REWRITE_GENERATION); Signed-off-by: Matan Breizman <[email protected]>
1 parent 7ec88cc commit c163fc0

File tree

2 files changed

+1
-1
lines changed

2 files changed

+1
-1
lines changed

src/common/options/crimson.yaml.in

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -231,6 +231,7 @@ options:
231231
level: advanced
232232
desc: The number of generations in the hot tier or the whole SeaStore instance if there's only one tier.
233233
default: 5
234+
min: 5
234235
- name: seastore_cold_tier_generations
235236
type: uint
236237
level: advanced

src/crimson/os/seastore/extent_placement_manager.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,6 @@ void ExtentPlacementManager::init(
203203
"hot_tier_generations{} , cold_tier_generations {}",
204204
dynamic_max_rewrite_generation, hot_tier_generations,
205205
cold_tier_generations);
206-
// TODO: hot_tier_generations should have a minumum..
207206
ceph_assert(dynamic_max_rewrite_generation > MIN_REWRITE_GENERATION);
208207

209208
if (trimmer->get_backend_type() == backend_type_t::SEGMENTED) {

0 commit comments

Comments
 (0)