Skip to content

Commit c2bb1a2

Browse files
authored
Merge pull request ceph#56469 from asm0deuz/bz2270211_ganesha_nlm
mgr/cephadm: Allows enabling NFS Ganesha NLM Reviewed-by: Adam King <[email protected]>
2 parents 05c9d46 + 2933191 commit c2bb1a2

File tree

4 files changed

+6
-2
lines changed

4 files changed

+6
-2
lines changed

src/pybind/mgr/cephadm/services/nfs.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,7 @@ def get_ganesha_conf() -> str:
120120
"bind_addr": bind_addr,
121121
"haproxy_hosts": [],
122122
"nfs_idmap_conf": nfs_idmap_conf,
123+
"enable_nlm": str(spec.enable_nlm).lower(),
123124
}
124125
if spec.enable_haproxy_protocol:
125126
context["haproxy_hosts"] = self._haproxy_hosts()

src/pybind/mgr/cephadm/templates/services/nfs/ganesha.conf.j2

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# {{ cephadm_managed }}
22
NFS_CORE_PARAM {
3-
Enable_NLM = false;
3+
Enable_NLM = {{ enable_nlm }};
44
Enable_RQUOTA = false;
55
Protocols = 4;
66
NFS_Port = {{ port }};

src/pybind/mgr/cephadm/tests/test_services.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2509,6 +2509,7 @@ def fake_keys():
25092509
hosts=['host1', 'host2']),
25102510
port=12049,
25112511
enable_haproxy_protocol=True,
2512+
enable_nlm=True,
25122513
)
25132514

25142515
ispec = IngressSpec(
@@ -2578,7 +2579,7 @@ def fake_keys():
25782579
nfs_ganesha_txt = (
25792580
"# This file is generated by cephadm.\n"
25802581
'NFS_CORE_PARAM {\n'
2581-
' Enable_NLM = false;\n'
2582+
' Enable_NLM = true;\n'
25822583
' Enable_RQUOTA = false;\n'
25832584
' Protocols = 4;\n'
25842585
' NFS_Port = 2049;\n'

src/python-common/ceph/deployment/service_spec.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1136,6 +1136,7 @@ def __init__(self,
11361136
networks: Optional[List[str]] = None,
11371137
port: Optional[int] = None,
11381138
virtual_ip: Optional[str] = None,
1139+
enable_nlm: bool = False,
11391140
enable_haproxy_protocol: bool = False,
11401141
extra_container_args: Optional[GeneralArgList] = None,
11411142
extra_entrypoint_args: Optional[GeneralArgList] = None,
@@ -1153,6 +1154,7 @@ def __init__(self,
11531154
self.virtual_ip = virtual_ip
11541155
self.enable_haproxy_protocol = enable_haproxy_protocol
11551156
self.idmap_conf = idmap_conf
1157+
self.enable_nlm = enable_nlm
11561158

11571159
def get_port_start(self) -> List[int]:
11581160
if self.port:

0 commit comments

Comments
 (0)