Merge pull request ceph#56586 from tchaikov/wip-erasure-code-new

erasure-code: use new/delete to alloc/free coefficients array

Reviewed-by: Samuel Just <[email protected]>

Author: yuriw

src/erasure-code/isa/ErasureCodeIsa.cc

@@ -379,7 +379,10 @@ ErasureCodeIsaDefault::prepare()
     dout(10) << "[ cache tables ] creating coeff for k=" <<
       k << " m=" << m << dendl;
     // build encoding coefficients which need to be computed once for each (k,m)
-    encode_coeff = (unsigned char*) malloc(k * (m + k));
+    //
+    // the coeff array is freed by ErasureCodeIsaTableCache::setEncodingCoefficient
+    // or ErasureCodeIsaTableCache::~ErasureCodeIsaTableCache()
+    encode_coeff = new unsigned char[k * (m + k)];
 
     if (matrixtype == kVandermonde)
       gf_gen_rs_matrix(encode_coeff, k + m, k);
@@ -398,7 +401,7 @@ ErasureCodeIsaDefault::prepare()
     dout(10) << "[ cache tables ] creating tables for k=" <<
       k << " m=" << m << dendl;
     // build encoding table which needs to be computed once for each (k,m)
-    encode_tbls = (unsigned char*) malloc(k * (m + k)*32);
+    encode_tbls = new unsigned char[k * (m + k)*32];
     ec_init_tables(k, m, &encode_coeff[k * k], encode_tbls);
 
     // either our new created table is stored or if it has been

src/erasure-code/isa/ErasureCodeIsaTableCache.cc

@@ -62,7 +62,7 @@ ErasureCodeIsaTableCache::~ErasureCodeIsaTableCache()
       for (table_it = tables_it->second.begin(); table_it != tables_it->second.end(); ++table_it) {
         if (table_it->second) {
           if (*(table_it->second)) {
-            delete *(table_it->second);
+            delete[] *(table_it->second);
           }
           delete table_it->second;
         }
@@ -75,7 +75,7 @@ ErasureCodeIsaTableCache::~ErasureCodeIsaTableCache()
       for (table_it = tables_it->second.begin(); table_it != tables_it->second.end(); ++table_it) {
         if (table_it->second) {
           if (*(table_it->second)) {
-            delete *(table_it->second);
+            delete[] *(table_it->second);
           }
           delete table_it->second;
         }
@@ -211,7 +211,7 @@ ErasureCodeIsaTableCache::setEncodingCoefficient(int matrix, int k, int m, unsig
   if (*ec_out_coeff) {
     // somebody might have deposited these coefficients in the meanwhile, so clean
     // the input coefficients and return the stored ones
-    free (ec_in_coeff);
+    delete[] ec_in_coeff;
     return *ec_out_coeff;
   } else {
     // we store the provided input coefficients and return these