Merge pull request ceph#59564 from Matan-B/wip-matanb-crimson-osd-release

crimson/osd: write require_osd_release only when needed

Reviewed-by: Samuel Just <[email protected]>

Author: Matan-B

src/crimson/osd/osd.cc

@@ -1557,10 +1557,18 @@ seastar::future<> OSD::handle_peering_op(
 
 seastar::future<> OSD::check_osdmap_features()
 {
+  LOG_PREFIX(OSD::check_osdmap_features);
   assert(seastar::this_shard_id() == PRIMARY_CORE);
-  return store.write_meta(
-      "require_osd_release",
-      stringify((int)osdmap->require_osd_release));
+  if (osdmap->require_osd_release != last_require_osd_release) {
+    DEBUG("updating require_osd_release from {} to {}",
+          to_string(last_require_osd_release),
+          to_string(osdmap->require_osd_release));
+    last_require_osd_release = osdmap->require_osd_release;
+    return store.write_meta(
+        "require_osd_release",
+        stringify((int)osdmap->require_osd_release));
+  }
+  return seastar::now();
 }
 
 seastar::future<> OSD::prepare_to_stop()

src/crimson/osd/osd.h

@@ -234,6 +234,8 @@ class OSD final : public crimson::net::Dispatcher,
 private:
   crimson::common::gate_per_shard gate;
 
+  ceph_release_t last_require_osd_release{ceph_release_t::unknown};
+
   seastar::promise<> stop_acked;
   void got_stop_ack() {
     stop_acked.set_value();