Skip to content

Commit cd50b3f

Browse files
author
Aashish Sharma
committed
mgr/dashboard: fix typo in Multi-Cluster > Manager Cluster to Manage Clusters
This PR fixes regression caused by this commit - ceph@24b2716 Fixes: https://tracker.ceph.com/issues/67194 Signed-off-by: Aashish Sharma <[email protected]>
1 parent 492a769 commit cd50b3f

File tree

2 files changed

+49
-4
lines changed

2 files changed

+49
-4
lines changed

src/pybind/mgr/dashboard/frontend/src/app/core/navigation/navigation/navigation.component.html

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -104,10 +104,10 @@
104104
[useRouter]="true"
105105
class="tc_submenuitem tc_submenuitem_multiCluster_overview"><span i18n>Overview</span></cds-sidenav-item>
106106
<cds-sidenav-item route="/multi-cluster/manage-clusters"
107-
title="Manager Cluster"
107+
title="Manage Clusters"
108108
i18n-title
109109
[useRouter]="true"
110-
class="tc_submenuitem tc_submenuitem_multiCluster_manage_clusters"><span i18n>Manager Cluster</span></cds-sidenav-item>
110+
class="tc_submenuitem tc_submenuitem_multiCluster_manage_clusters"><span i18n>Manage Clusters</span></cds-sidenav-item>
111111
</cds-sidenav-menu>
112112
<!-- Cluster -->
113113
<cds-sidenav-menu title="Cluster"
@@ -190,7 +190,8 @@
190190
<cds-sidenav-item route="/block/nvmeof"
191191
[useRouter]="true"
192192
title="NVMe/TCP"
193-
i18n-title><span i18n>NVMe/TCP</span></cds-sidenav-item>
193+
i18n-title
194+
class="tc_submenuitem tc_submenuitem_block_nvme"><span i18n>NVMe/TCP</span></cds-sidenav-item>
194195
</cds-sidenav-menu>
195196
<!-- Object Storage -->
196197
<cds-sidenav-menu title="Object"
@@ -219,7 +220,7 @@
219220
title="Multi-site"
220221
i18n-title
221222
[useRouter]="true"
222-
class="tc_submenuitem tc_submenuitem_rgw_buckets"><span i18n>Multi-site</span></cds-sidenav-item>
223+
class="tc_submenuitem tc_submenuitem_rgw_multi-site"><span i18n>Multi-site</span></cds-sidenav-item>
223224
<cds-sidenav-item route="/rgw/daemon"
224225
title="Gateways"
225226
i18n-title

src/pybind/mgr/dashboard/frontend/src/app/core/navigation/navigation/navigation.component.spec.ts

Lines changed: 44 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -219,4 +219,48 @@ describe('NavigationComponent', () => {
219219
});
220220
}
221221
});
222+
223+
describe('Test Side Navigation Text', () => {
224+
it('should display correct text for navigation items', () => {
225+
fixture.detectChanges();
226+
227+
const expectedTexts = {
228+
'.tc_menuitem_dashboard': 'Dashboard',
229+
'.tc_submenuitem_multiCluster_overview': 'Overview',
230+
'.tc_submenuitem_multiCluster_manage_clusters': 'Manage Clusters',
231+
'.tc_submenuitem_cluster_pool': 'Pools',
232+
'.tc_submenuitem_cluster_hosts': 'Hosts',
233+
'.tc_submenuitem_cluster_inventory': 'Physical Disks',
234+
'.tc_submenuitem_admin_services': 'Services',
235+
'.tc_submenuitem_cluster_monitor': 'Monitors',
236+
'.tc_submenuitem_cluster_osds': 'OSDs',
237+
'.tc_submenuitem_cluster_crush': 'CRUSH Map',
238+
'.tc_submenuitem_admin_configuration': 'Configuration',
239+
'.tc_submenuitem_admin_modules': 'Manager Modules',
240+
'.tc_submenuitem_admin_users': 'Ceph Users',
241+
'.tc_submenuitem_admin_upgrade': 'Upgrade',
242+
'.tc_submenuitem_observe_log': 'Logs',
243+
'.tc_submenuitem_observe_monitoring': 'Alerts',
244+
'.tc_submenuitem_block_images': 'Images',
245+
'.tc_submenuitem_block_mirroring': 'Mirroring',
246+
'.tc_submenuitem_block_iscsi': 'iSCSI',
247+
'.tc_submenuitem_block_nvme': 'NVMe/TCP',
248+
'.tc_submenuitem_rgw_overview': 'Overview',
249+
'.tc_submenuitem_rgw_buckets': 'Buckets',
250+
'.tc_submenuitem_rgw_users': 'Users',
251+
'.tc_submenuitem_rgw_multi-site': 'Multi-site',
252+
'.tc_submenuitem_rgw_daemons': 'Gateways',
253+
'.tc_submenuitem_rgw_nfs': 'NFS',
254+
'.tc_submenuitem_rgw_configuration': 'Configuration',
255+
'.tc_submenuitem_file_cephfs': 'File Systems',
256+
'.tc_submenuitem_file_nfs': 'NFS'
257+
};
258+
259+
for (const [selector, expectedText] of Object.entries(expectedTexts)) {
260+
const element = fixture.debugElement.query(By.css(selector));
261+
expect(element).toBeTruthy();
262+
expect(element.nativeElement.textContent.trim()).toBe(expectedText);
263+
}
264+
});
265+
});
222266
});

0 commit comments

Comments
 (0)