crimson: remove unused OperationThrottler::with_throttle

It's now unused, and these combinator style wrappers are easy to
misuse and hard to read compared with RAII and coroutines.

Signed-off-by: Samuel Just <[email protected]>

Author: athanatos

src/crimson/osd/osd_operation.h

@@ -334,17 +334,6 @@ class OperationThrottler : public BlockerT<OperationThrottler>,
     });
   }
 
-  template <typename F>
-  auto with_throttle(
-    crimson::osd::scheduler::params_t params,
-    F &&f) {
-    return acquire_throttle(params)
-      .then(std::forward<F>(f))
-      .finally([this] {
-	release_throttle();
-      });
-  }
-
 private:
   void dump_detail(Formatter *f) const final;
 

src/crimson/osd/shard_services.h

@@ -593,7 +593,6 @@ class ShardServices : public OSDMapService {
   }
 
   FORWARD_TO_OSD_SINGLETON(get_pool_info)
-  FORWARD(with_throttle, with_throttle, local_state.throttler)
   FORWARD(get_throttle, get_throttle, local_state.throttler)
 
   FORWARD_TO_OSD_SINGLETON(build_incremental_map_msg)