Skip to content

Commit ceeb9e5

Browse files
authored
Merge pull request ceph#55634 from cbodley/wip-64480
rgw: RGWSI_SysObj_Cache::remove() invalidates after successful delete Reviewed-by: Daniel Gryniewicz <[email protected]>
2 parents 57f90b1 + 0eebbc3 commit ceeb9e5

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

src/rgw/services/svc_sys_obj_cache.cc

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,11 @@ int RGWSI_SysObj_Cache::remove(const DoutPrefixProvider *dpp,
8989
optional_yield y)
9090

9191
{
92+
int r = RGWSI_SysObj_Core::remove(dpp, objv_tracker, obj, y);
93+
if (r < 0) {
94+
return r;
95+
}
96+
9297
rgw_pool pool;
9398
string oid;
9499
normalize_pool_and_obj(obj.pool, obj.oid, pool, oid);
@@ -97,12 +102,12 @@ int RGWSI_SysObj_Cache::remove(const DoutPrefixProvider *dpp,
97102
cache.invalidate_remove(dpp, name);
98103

99104
ObjectCacheInfo info;
100-
int r = distribute_cache(dpp, name, obj, info, INVALIDATE_OBJ, y);
105+
r = distribute_cache(dpp, name, obj, info, INVALIDATE_OBJ, y);
101106
if (r < 0) {
102107
ldpp_dout(dpp, 0) << "ERROR: " << __func__ << "(): failed to distribute cache: r=" << r << dendl;
103-
}
108+
} // not fatal
104109

105-
return RGWSI_SysObj_Core::remove(dpp, objv_tracker, obj, y);
110+
return 0;
106111
}
107112

108113
int RGWSI_SysObj_Cache::read(const DoutPrefixProvider *dpp,

0 commit comments

Comments
 (0)