Merge pull request ceph#58068 from rhcs-dashboard/disable-telemetry-notifications-in-e2e

mgr/dashboard: disable telemetry notification in e2e 

Reviewed-by: afreen23 <NOT@FOUND>
Reviewed-by: nmunet <NOT@FOUND>

Author: nizamial09

src/pybind/mgr/dashboard/frontend/cypress/e2e/block/images.e2e-spec.ts

@@ -11,7 +11,7 @@ describe('Images page', () => {
     cy.login();
     // Need pool for image testing
     pools.navigateTo('create');
-    pools.create(poolName, 8, 'rbd');
+    pools.create(poolName, 8, ['rbd']);
     pools.existTableCell(poolName);
   });
 

src/pybind/mgr/dashboard/frontend/cypress/e2e/block/mirroring.e2e-spec.ts

@@ -32,7 +32,7 @@ describe('Mirroring page', () => {
       cy.ceph2Login();
       cy.login();
       pools.navigateTo('create');
-      pools.create(poolName, 8, 'rbd');
+      pools.create(poolName, 8, ['rbd']);
       pools.navigateTo();
       pools.existTableCell(poolName, true);
       mirroring.navigateTo();
@@ -49,16 +49,17 @@ describe('Mirroring page', () => {
         // so writing the code to copy the token inside the origin manually
         // rather than using a function call
         // @ts-ignore
+        cy.ceph2Login();
         cy.origin(url, { args }, ({ name, bootstrapToken }) => {
           // Create an rbd pool in the second cluster
+          cy.visit('#/pool/create').wait(100);
 
           // Login to the second cluster
           // Somehow its not working with the cypress login function
-          cy.visit('#/pool/create').wait(100);
-
           cy.get('[name=username]').type('admin');
           cy.get('#password').type('admin');
           cy.get('[type=submit]').click();
+
           cy.get('input[name=name]').clear().type(name);
           cy.get(`select[name=poolType]`).select('replicated');
           cy.get(`select[name=poolType] option:checked`).contains('replicated');
@@ -93,7 +94,7 @@ describe('Mirroring page', () => {
 
     beforeEach(() => {
       pools.navigateTo('create'); // Need pool for mirroring testing
-      pools.create(poolName, 8, 'rbd');
+      pools.create(poolName, 8, ['rbd']);
       pools.navigateTo();
       pools.existTableCell(poolName, true);
     });

src/pybind/mgr/dashboard/frontend/cypress/e2e/cluster/logs.e2e-spec.ts

@@ -46,7 +46,7 @@ describe('Logs page', () => {
   describe('audit logs respond to pool creation and deletion test', () => {
     it('should create pool and check audit logs reacted', () => {
       pools.navigateTo('create');
-      pools.create(poolname, 8, 'rbd');
+      pools.create(poolname, 8, ['rbd']);
       pools.navigateTo();
       pools.existTableCell(poolname, true);
       logs.checkAuditForPoolFunction(poolname, 'create', hour, minute);

src/pybind/mgr/dashboard/frontend/cypress/e2e/cluster/services.po.ts

@@ -49,7 +49,9 @@ export class ServicesPageHelper extends PageHelper {
       switch (serviceType) {
         case 'rgw':
           cy.get('#service_id').type('foo');
-          unmanaged ? cy.get('label[for=unmanaged]').click() : cy.get('#count').type(String(count));
+          unmanaged
+            ? cy.get('label[for=unmanaged]').click()
+            : cy.get('#count').clear().type(String(count));
           break;
 
         case 'ingress':
@@ -65,12 +67,16 @@ export class ServicesPageHelper extends PageHelper {
 
         case 'nfs':
           cy.get('#service_id').type('testnfs');
-          unmanaged ? cy.get('label[for=unmanaged]').click() : cy.get('#count').type(String(count));
+          unmanaged
+            ? cy.get('label[for=unmanaged]').click()
+            : cy.get('#count').clear().type(String(count));
           break;
 
         case 'smb':
           cy.get('#service_id').type('testsmb');
-          unmanaged ? cy.get('label[for=unmanaged]').click() : cy.get('#count').type(String(count));
+          unmanaged
+            ? cy.get('label[for=unmanaged]').click()
+            : cy.get('#count').clear().type(String(count));
           cy.get('#cluster_id').type('cluster_foo');
           cy.get('#config_uri').type('rados://.smb/foo/scc.toml');
           break;
@@ -96,7 +102,9 @@ export class ServicesPageHelper extends PageHelper {
 
         default:
           cy.get('#service_id').type('test');
-          unmanaged ? cy.get('label[for=unmanaged]').click() : cy.get('#count').type(String(count));
+          unmanaged
+            ? cy.get('label[for=unmanaged]').click()
+            : cy.get('#count').clear().type(String(count));
           break;
       }
       if (serviceType === 'snmp-gateway') {

src/pybind/mgr/dashboard/frontend/cypress/e2e/pools/pools.e2e-spec.ts

@@ -28,14 +28,14 @@ describe('Pools page', () => {
   });
 
   describe('Create, update and destroy', () => {
-    it('should create a pool with mirroring enabled', () => {
+    it('should create a pool', () => {
       pools.existTableCell(poolName, false);
       pools.navigateTo('create');
-      pools.create(poolName, 8, 'rbd');
+      pools.create(poolName, 8, ['rbd']);
       pools.existTableCell(poolName);
     });
 
-    it('should edit a pools placement group and check if mirroring is enabled', () => {
+    it('should edit a pools placement group', () => {
       pools.existTableCell(poolName);
       pools.edit_pool_pg(poolName, 32);
     });
@@ -50,4 +50,22 @@ describe('Pools page', () => {
       pools.delete(poolName);
     });
   });
+
+  describe('Pool with mirroring', () => {
+    it('should create a pool with mirroring enabled', () => {
+      pools.existTableCell(poolName, false);
+      pools.navigateTo('create');
+      pools.create(poolName, 8, ['rbd'], true);
+      pools.existTableCell(poolName);
+    });
+
+    it('should edit a pools placement group with mirroring enabled', () => {
+      pools.existTableCell(poolName);
+      pools.edit_pool_pg(poolName, 32, true, true);
+    });
+
+    it('should delete the pool', () => {
+      pools.delete(poolName);
+    });
+  });
 });

src/pybind/mgr/dashboard/frontend/cypress/e2e/pools/pools.po.ts

@@ -14,7 +14,7 @@ export class PoolPageHelper extends PageHelper {
   }
 
   @PageHelper.restrictTo(pages.create.url)
-  create(name: string, placement_groups: number, ...apps: string[]) {
+  create(name: string, placement_groups: number, apps: string[], mirroring = false) {
     cy.get('input[name=name]').clear().type(name);
 
     this.isPowerOf2(placement_groups);
@@ -25,15 +25,19 @@ export class PoolPageHelper extends PageHelper {
     this.selectOption('pgAutoscaleMode', 'off'); // To show pgNum field
     cy.get('input[name=pgNum]').clear().type(`${placement_groups}`);
     this.setApplications(apps);
-    cy.get('#rbdMirroring').check({ force: true });
+    if (mirroring) {
+      cy.get('#rbdMirroring').check({ force: true });
+    }
     cy.get('cd-submit-button').click();
   }
 
-  edit_pool_pg(name: string, new_pg: number, wait = true) {
+  edit_pool_pg(name: string, new_pg: number, wait = true, mirroring = false) {
     this.isPowerOf2(new_pg);
     this.navigateEdit(name);
 
-    cy.get('#rbdMirroring').should('be.checked');
+    if (mirroring) {
+      cy.get('#rbdMirroring').should('be.checked');
+    }
 
     cy.get('input[name=pgNum]').clear().type(`${new_pg}`);
     cy.get('cd-submit-button').click();

src/pybind/mgr/dashboard/frontend/cypress/e2e/ui/language.po.ts

@@ -10,6 +10,6 @@ export class LanguagePageHelper extends PageHelper {
   }
 
   getAllLanguages() {
-    return cy.get('cd-language-selector cds-header-menu');
+    return cy.get('cd-language-selector cds-header-menu cds-header-item');
   }
 }

src/pybind/mgr/dashboard/frontend/cypress/e2e/ui/notification.e2e-spec.ts

@@ -9,7 +9,7 @@ describe('Notification page', () => {
   before(() => {
     cy.login();
     pools.navigateTo('create');
-    pools.create(poolName, 8, 'rbd');
+    pools.create(poolName, 8, ['rbd']);
     pools.edit_pool_pg(poolName, 4, false);
   });
 

src/pybind/mgr/dashboard/frontend/cypress/support/commands.ts

@@ -27,6 +27,7 @@ const fillAuth = () => {
   window.localStorage.setItem('user_pwd_expiration_date', auth.pwdExpirationDate);
   window.localStorage.setItem('user_pwd_update_required', auth.pwdUpdateRequired);
   window.localStorage.setItem('sso', auth.sso);
+  window.localStorage.setItem('telemetry_notification_hidden', 'true'); // disable telemetry notification in e2e
 };
 
 Cypress.Commands.add('login', (username, password) => {
@@ -68,6 +69,7 @@ Cypress.Commands.add('ceph2Login', (username, password) => {
           window.localStorage.setItem('user_pwd_expiration_date', pwdExpirationDate);
           window.localStorage.setItem('user_pwd_update_required', pwdUpdateRequired);
           window.localStorage.setItem('sso', sso);
+          window.localStorage.setItem('telemetry_notification_hidden', 'true'); // disable telemetry notification in e2e
         }
       );
     });