Merge pull request ceph#65999 from anoopcs9/smb-disable-posix-locking

adk3798 · web-flow · commit d3199cd94c19 · 2025-11-17T11:29:30.000-05:00
mgr/smb: Disable posix locking in share definition

Reviewed-by: Adam King &lt;adking@redhat.com&gt;
diff --git a/qa/suites/orch/cephadm/smb/tasks/deploy_smb_basic.yaml b/qa/suites/orch/cephadm/smb/tasks/deploy_smb_basic.yaml
@@ -60,6 +60,7 @@ tasks:
             "disable spoolss" = "yes"
             "guest ok" = "no"
             "smbd profiling level" = "on"
+            "posix locking" = "no"
             [globals.domain.options]
             security = "USER"
             workgroup = "STANDALONE1"
diff --git a/qa/suites/orch/cephadm/smb/tasks/deploy_smb_domain.yaml b/qa/suites/orch/cephadm/smb/tasks/deploy_smb_domain.yaml
@@ -59,6 +59,7 @@ tasks:
           "disable spoolss" = "yes"
           "guest ok" = "no"
           "smbd profiling level" = "on"
+          "posix locking" = "no"
           [globals.domain.options]
           security = "ads"
           workgroup = "DOMAIN1"
diff --git a/src/pybind/mgr/smb/handler.py b/src/pybind/mgr/smb/handler.py
@@ -721,6 +721,7 @@ def _generate_share(
             'kernel share modes': 'no',
             'x:ceph:id': f'{share.cluster_id}.{share.share_id}',
             'smbd profiling share': 'yes',
+            'posix locking': 'no',
         }
     }
     if share.comment is not None:

Original file line number	Diff line number	Diff line change
`@@ -721,6 +721,7 @@ def _generate_share(`
`721`	`721`	`'kernel share modes': 'no',`
`722`	`722`	`'x:ceph:id': f'{share.cluster_id}.{share.share_id}',`
`723`	`723`	`'smbd profiling share': 'yes',`
	`724`	`+ 'posix locking': 'no',`
`724`	`725`	`}`
`725`	`726`	`}`
`726`	`727`	`if share.comment is not None:`