Merge pull request ceph#59143 from Sean10/fix_rados_pybind_zero_param

pybind/rados: fix the incorrect order of offset,length in WriteOp.zero

Reviewed-by: Radoslaw Zarzynski <[email protected]>
Reviewed-by: Patrick Donnelly <[email protected]>

Author: yuriw

PendingReleaseNotes

@@ -60,6 +60,10 @@
   fuse client for `fallocate` for the default case (i.e. mode == 0) since
   CephFS does not support disk space reservation. The only flags supported are
   `FALLOC_FL_KEEP_SIZE` and `FALLOC_FL_PUNCH_HOLE`.
+* pybind/rados: Fixes WriteOp.zero() in the original reversed order of arguments
+  `offset` and `length`. When pybind calls WriteOp.zero(), the argument passed
+  does not match rados_write_op_zero, and offset and length are swapped, which
+  results in an unexpected response.
 
 * The HeadBucket API now reports the `X-RGW-Bytes-Used` and `X-RGW-Object-Count`
   headers only when the `read-stats` querystring is explicitly included in the

src/pybind/rados/rados.pyx

@@ -1870,7 +1870,7 @@ cdef class WriteOp(object):
             uint64_t _offset = offset
 
         with nogil:
-            rados_write_op_zero(self.write_op, _length, _offset)
+            rados_write_op_zero(self.write_op, _offset, _length)
 
     def truncate(self, offset: int):
         """

src/test/pybind/test_rados.py

@@ -515,6 +515,11 @@ def test_write_ops(self):
             self.ioctx.operate_write_op(write_op, "write_ops")
             eq(self.ioctx.read('write_ops'), b'12\x00\x005')
 
+            write_op.write_full(b'12345')
+            write_op.zero(0, 2)
+            self.ioctx.operate_write_op(write_op, "write_ops")
+            eq(self.ioctx.read('write_ops'), b'\x00\x00345')
+
             write_op.write_full(b'12345')
             write_op.truncate(2)
             self.ioctx.operate_write_op(write_op, "write_ops")