Skip to content

Commit daa455c

Browse files
mgr/nfs: fix unintentional recursion
The `exports` property of the ExportMgr exists to cache the exports configuration found in the .nfs namespace. Using that property within the property method is probably not intentional and is probably only working due to the lucky construction of the _exports dict immediately after the None check so that the _exports dict is returned (and is a mutable type). Signed-off-by: John Mulligan <[email protected]>
1 parent 4d09660 commit daa455c

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/pybind/mgr/nfs/export.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ def exports(self) -> Dict[str, List[Export]]:
196196
for cluster_id in known_cluster_ids(self.mgr):
197197
self.export_conf_objs = [] # type: List[Export]
198198
self._read_raw_config(cluster_id)
199-
self.exports[cluster_id] = self.export_conf_objs
199+
self._exports[cluster_id] = self.export_conf_objs
200200
log.info("Exports parsed successfully %s", self.exports.items())
201201
return self._exports
202202

0 commit comments

Comments
 (0)