Skip to content

Commit dc4bd3e

Browse files
qa: improve and add commit ID to comment for context
The comment was unclear without looking at previous version of code. Therefore improve comment a bit and add link to commit ID due to which this comment was introduced to give future readers context. Also, place the comment before the command arguments. This too adds the context. Signed-off-by: Rishabh Dave <[email protected]>
1 parent d622325 commit dc4bd3e

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

qa/tasks/workunit.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -441,8 +441,10 @@ def _run_tests(ctx, refspec, role, tests, env, basedir,
441441
remote.run(logger=log.getChild(role), args=args, timeout=(60*60))
442442
finally:
443443
log.info('Stopping %s on %s...', tests, role)
444+
# N.B. unlike before, don't cleanup path under variable "scratch_tmp"
445+
# here! If the mount is broken then rm will hang. For context, see
446+
# commit d4b8f94cf8d95ebb277b550fc6ebc3468052a39c.
444447
args=['sudo', 'rm', '-rf', '--', workunits_file, clonedir]
445-
# N.B. don't cleanup scratch_tmp! If the mount is broken then rm will hang.
446448
remote.run(
447449
logger=log.getChild(role),
448450
args=args,

0 commit comments

Comments
 (0)