Skip to content

Commit e1a0284

Browse files
committed
common/TrackedOp: rename and raise prio of slow op perfcounter
1. TrackedOp is a common class, mon and mds alse use it. 2. Set prio level of l_trackedop_slow_op_count to PRIO_USEFUL, we can get change of slow op of daemon from prometheus metrics, it's very interesting Signed-off-by: Yite Gu <[email protected]>
1 parent 3fbfd18 commit e1a0284

File tree

2 files changed

+9
-7
lines changed

2 files changed

+9
-7
lines changed

src/common/TrackedOp.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ void OpHistory::_insert_delayed(const utime_t& now, TrackedOpRef op)
9090
arrived.insert(make_pair(op->get_initiated(), op));
9191
if (opduration >= history_slow_op_threshold.load()) {
9292
slow_op.insert(make_pair(op->get_initiated(), op));
93-
logger->inc(l_osd_slow_op_count);
93+
logger->inc(l_trackedop_slow_op_count);
9494
}
9595
cleanup(now);
9696
}

src/common/TrackedOp.h

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -52,9 +52,9 @@ class OpHistoryServiceThread : public Thread
5252
};
5353

5454
enum {
55-
l_osd_slow_op_first = 1000,
56-
l_osd_slow_op_count,
57-
l_osd_slow_op_last,
55+
l_trackedop_slow_op_first = 1000,
56+
l_trackedop_slow_op_count,
57+
l_trackedop_slow_op_last,
5858
};
5959

6060
class OpHistory {
@@ -75,9 +75,11 @@ class OpHistory {
7575

7676
public:
7777
OpHistory(CephContext *c) : cct(c), opsvc(this) {
78-
PerfCountersBuilder b(cct, "osd-slow-ops",
79-
l_osd_slow_op_first, l_osd_slow_op_last);
80-
b.add_u64_counter(l_osd_slow_op_count, "slow_ops_count",
78+
PerfCountersBuilder b(cct, "trackedop",
79+
l_trackedop_slow_op_first, l_trackedop_slow_op_last);
80+
b.set_prio_default(PerfCountersBuilder::PRIO_USEFUL);
81+
82+
b.add_u64_counter(l_trackedop_slow_op_count, "slow_ops_count",
8183
"Number of operations taking over ten second");
8284

8385
logger.reset(b.create_perf_counters());

0 commit comments

Comments
 (0)