qa/suites: do not use vip.exec when it is not needed

Convert a number of uses of `vip.exec` to basic `exec`. When the
replacement pattern `{{VIP<x>}}` is not present vip.exec and exec
are essentially the same. This means that the remaining uses of
`vip.exec` actually need vip variable substitution.

Signed-off-by: John Mulligan <[email protected]>

Author: phlogistonjohn

qa/suites/orch/cephadm/mgr-nfs-upgrade/2-nfs.yaml

@@ -1,7 +1,7 @@
 tasks:
 
 # stop kernel nfs server, if running
-- vip.exec:
+- exec:
     all-hosts:
       - systemctl stop nfs-server
 
@@ -20,7 +20,7 @@ tasks:
       # we can't do wait_for_service here because with octopus it's nfs.ganesha-foo not nfs.foo
       - while ! ceph orch ls | grep nfs | grep 2/2 ; do sleep 1 ; done
 
-- vip.exec:
+- exec:
     host.a:
       - mkdir /mnt/foo
       - while ! mount -t nfs $(hostname):/fake /mnt/foo -o sync ; do sleep 5 ; done

qa/suites/orch/cephadm/mgr-nfs-upgrade/4-final.yaml

@@ -3,7 +3,7 @@ overrides:
     log-ignorelist:
       - CEPHADM_REFRESH_FAILED
 tasks:
-- vip.exec:
+- exec:
     host.a:
       - umount /mnt/foo
 - cephadm.shell:

qa/suites/orch/cephadm/smoke-roleless/2-services/nfs-haproxy-proto.yaml

@@ -7,7 +7,7 @@ tasks:
       - ceph orch device ls --refresh
 
 # stop kernel nfs server, if running
-- vip.exec:
+- exec:
     all-hosts:
       - systemctl stop nfs-server
 

qa/suites/orch/cephadm/smoke-roleless/2-services/nfs-ingress-rgw-bucket.yaml

@@ -7,7 +7,7 @@ tasks:
       - ceph orch device ls --refresh
 
 # stop kernel nfs server, if running
-- vip.exec:
+- exec:
     all-hosts:
       - systemctl stop nfs-server
 
@@ -16,7 +16,7 @@ tasks:
       - ceph orch apply rgw foorgw --port 8800
       - ceph nfs cluster create foo --ingress --virtual-ip {{VIP0}}/{{VIPPREFIXLEN}}
 
-- vip.exec:
+- exec:
     host.a:
       - dnf install -y python3-boto3 || apt install -y python3-boto3
       - /home/ubuntu/cephtest/cephadm shell radosgw-admin user create --uid foouser --display-name foo > /tmp/user.json
@@ -79,7 +79,7 @@ tasks:
       print(data.getvalue())
       assert data.getvalue().decode() == 'test\n'
 
-- vip.exec:
+- exec:
     host.a:
       - umount /mnt/foo
 

qa/suites/orch/cephadm/smoke-roleless/2-services/nfs-ingress-rgw-user.yaml

@@ -7,7 +7,7 @@ tasks:
       - ceph orch device ls --refresh
 
 # stop kernel nfs server, if running
-- vip.exec:
+- exec:
     all-hosts:
       - systemctl stop nfs-server
 
@@ -16,7 +16,7 @@ tasks:
       - ceph orch apply rgw foorgw --port 8800
       - ceph nfs cluster create foo --ingress --virtual-ip {{VIP0}}/{{VIPPREFIXLEN}}
 
-- vip.exec:
+- exec:
     host.a:
       - dnf install -y python3-boto3 || apt install -y python3-boto3
       - /home/ubuntu/cephtest/cephadm shell radosgw-admin user create --uid foouser --display-name foo > /tmp/user.json
@@ -80,7 +80,7 @@ tasks:
       print(data.getvalue())
       assert data.getvalue().decode() == 'test\n'
 
-- vip.exec:
+- exec:
     host.a:
       - umount /mnt/foo
 

qa/suites/orch/cephadm/smoke-roleless/2-services/nfs-ingress.yaml

@@ -7,7 +7,7 @@ tasks:
       - ceph orch device ls --refresh
 
 # stop kernel nfs server, if running
-- vip.exec:
+- exec:
     all-hosts:
       - systemctl stop nfs-server
 

qa/suites/orch/cephadm/smoke-roleless/2-services/nfs-ingress2.yaml

@@ -7,7 +7,7 @@ tasks:
       - ceph orch device ls --refresh
 
 # stop kernel nfs server, if running
-- vip.exec:
+- exec:
     all-hosts:
       - systemctl stop nfs-server
 
@@ -51,7 +51,7 @@ tasks:
 
 # take each ganesha down in turn.
 # simulate "failure" by deleting the container
-- vip.exec:
+- exec:
     all-hosts:
       - |
         echo "Check with $(hostname) ganesha(s) down..."

qa/suites/orch/cephadm/smoke-roleless/2-services/nfs-keepalive-only.yaml

@@ -7,7 +7,7 @@ tasks:
       - ceph orch device ls --refresh
 
 # stop kernel nfs server, if running
-- vip.exec:
+- exec:
     all-hosts:
       - systemctl stop nfs-server
 

qa/suites/orch/cephadm/smoke-roleless/2-services/nfs.yaml

@@ -1,7 +1,7 @@
 tasks:
 
 # stop kernel nfs server, if running
-- vip.exec:
+- exec:
     all-hosts:
       - systemctl stop nfs-server
 

qa/suites/orch/cephadm/smoke-roleless/2-services/nfs2.yaml

@@ -1,7 +1,7 @@
 tasks:
 
 # stop kernel nfs server, if running
-- vip.exec:
+- exec:
     all-hosts:
       - systemctl stop nfs-server