Merge pull request ceph#44859 from cfsnyder/wip-54112-rgw-segfault-init-fetch

cbodley · web-flow · commit e98697fdcb3b · 2022-03-08T08:31:54.000-05:00
rgw: fix segfault in UserAsyncRefreshHandler::init_fetch

Reviewed-by: Casey Bodley &lt;cbodley@redhat.com&gt;
diff --git a/src/rgw/services/svc_user_rados.cc b/src/rgw/services/svc_user_rados.cc
@@ -973,7 +973,6 @@ int RGWSI_User_RADOS::read_stats_async(const DoutPrefixProvider *dpp, RGWSI_Meta
   RGWGetUserStatsContext *cb = new RGWGetUserStatsContext(_cb);
   int r = cls_user_get_header_async(dpp, user_str, cb);
   if (r < 0) {
-    _cb->put();
     delete cb;
     return r;
   }

Original file line number	Diff line number	Diff line change
`@@ -973,7 +973,6 @@ int RGWSI_User_RADOS::read_stats_async(const DoutPrefixProvider *dpp, RGWSI_Meta`
`973`	`973`	`RGWGetUserStatsContext *cb = new RGWGetUserStatsContext(_cb);`
`974`	`974`	`int r = cls_user_get_header_async(dpp, user_str, cb);`
`975`	`975`	`if (r < 0) {`
`976`		`- _cb->put();`
`977`	`976`	`delete cb;`
`978`	`977`	`return r;`
`979`	`978`	`}`