Skip to content

Commit f5a36f2

Browse files
committed
src/rgw: Fixing event name
Received as "Noncurrent" instead of "NonCurrent" This PR fixes the issue: https://tracker.ceph.com/issues/59488 Signed-off-by: Kalpesh Pandya <[email protected]>
1 parent d5744c1 commit f5a36f2

File tree

3 files changed

+13
-7
lines changed

3 files changed

+13
-7
lines changed

src/rgw/rgw_lc.cc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1240,7 +1240,7 @@ class LCOpAction_NonCurrentExpiration : public LCOpAction {
12401240
int process(lc_op_ctx& oc) override {
12411241
auto& o = oc.o;
12421242
int r = remove_expired_obj(oc.dpp, oc, true,
1243-
{rgw::notify::ObjectExpirationNoncurrent});
1243+
{rgw::notify::ObjectExpirationNonCurrent});
12441244
if (r < 0) {
12451245
ldpp_dout(oc.dpp, 0) << "ERROR: remove_expired_obj (non-current expiration) "
12461246
<< oc.bucket << ":" << o.key
@@ -1383,7 +1383,7 @@ class LCOpAction_Transition : public LCOpAction {
13831383
<< "flags: " << oc.o.flags << dendl;
13841384
} else {
13851385
ret = remove_expired_obj(oc.dpp, oc, true,
1386-
{rgw::notify::ObjectTransitionNoncurrent});
1386+
{rgw::notify::ObjectTransitionNonCurrent});
13871387
ldpp_dout(oc.dpp, 20)
13881388
<< "delete_tier_obj Object(key:" << oc.o.key << ") not current "
13891389
<< "versioned_epoch: " << oc.o.versioned_epoch
@@ -1416,7 +1416,7 @@ class LCOpAction_Transition : public LCOpAction {
14161416
{rgw::notify::ObjectTransitionCurrent,
14171417
rgw::notify::LifecycleTransition});
14181418
} else {
1419-
event_types.push_back(rgw::notify::ObjectTransitionNoncurrent);
1419+
event_types.push_back(rgw::notify::ObjectTransitionNonCurrent);
14201420
}
14211421

14221422
std::unique_ptr<rgw::sal::Notification> notify =

src/rgw/rgw_notify_event_type.cc

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ namespace rgw::notify {
3131
case ObjectExpirationCurrent:
3232
return "s3:ObjectLifecycle:Expiration:Current";
3333
case ObjectExpirationNoncurrent:
34-
return "s3:ObjectLifecycle:Expiration:Noncurrent";
34+
return "s3:ObjectLifecycle:Expiration:NonCurrent";
3535
case ObjectExpirationDeleteMarker:
3636
return "s3:ObjectLifecycle:Expiration:DeleteMarker";
3737
case ObjectExpirationAbortMPU:
@@ -41,7 +41,7 @@ namespace rgw::notify {
4141
case ObjectTransitionCurrent:
4242
return "s3:ObjectLifecycle:Transition:Current";
4343
case ObjectTransitionNoncurrent:
44-
return "s3:ObjectLifecycle:Transition:Noncurrent";
44+
return "s3:ObjectLifecycle:Transition:NonCurrent";
4545
case ObjectSynced:
4646
return "s3:ObjectSynced:*";
4747
case ObjectSyncedCreate:
@@ -99,8 +99,10 @@ namespace rgw::notify {
9999
return ObjectExpiration;
100100
if (s == "s3:ObjectLifecycle:Expiration:Current")
101101
return ObjectExpirationCurrent;
102+
if (s == "s3:ObjectLifecycle:Expiration:NonCurrent")
103+
return ObjectExpirationNonCurrent;
102104
if (s == "s3:ObjectLifecycle:Expiration:Noncurrent")
103-
return ObjectExpirationNoncurrent;
105+
return ObjectExpirationNonCurrent;
104106
if (s == "s3:ObjectLifecycle:Expiration:DeleteMarker")
105107
return ObjectExpirationDeleteMarker;
106108
if (s == "s3:ObjectLifecycle:Expiration:AbortMultipartUpload")
@@ -109,8 +111,10 @@ namespace rgw::notify {
109111
return ObjectTransition;
110112
if (s == "s3:ObjectLifecycle:Transition:Current")
111113
return ObjectTransitionCurrent;
114+
if (s == "s3:ObjectLifecycle:Transition:NonCurrent")
115+
return ObjectTransitionNonCurrent;
112116
if (s == "s3:ObjectLifecycle:Transition:Noncurrent")
113-
return ObjectTransitionNoncurrent;
117+
return ObjectTransitionNonCurrent;
114118
if (s == "s3:ObjectSynced:*")
115119
return ObjectSynced;
116120
if (s == "s3:ObjectSynced:Create")

src/rgw/rgw_notify_event_type.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,13 @@ namespace rgw::notify {
2020
ObjectExpiration = 0xF00,
2121
ObjectExpirationCurrent = 0x100,
2222
ObjectExpirationNoncurrent = 0x200,
23+
ObjectExpirationNonCurrent = 0x200,
2324
ObjectExpirationDeleteMarker = 0x400,
2425
ObjectExpirationAbortMPU = 0x800,
2526
ObjectTransition = 0xF000,
2627
ObjectTransitionCurrent = 0x1000,
2728
ObjectTransitionNoncurrent = 0x2000,
29+
ObjectTransitionNonCurrent = 0x2000,
2830
ObjectSynced = 0xF0000,
2931
ObjectSyncedCreate = 0x10000,
3032
ObjectSyncedDelete = 0x20000,

0 commit comments

Comments
 (0)