Skip to content

Commit f6da8d7

Browse files
committed
mgr/dashboard: fix upgrade's cluster alerts popover
keep the legacy view so that it shows the alert types when opening the popover Fixes: https://tracker.ceph.com/issues/73733 Signed-off-by: Nizamudeen A <[email protected]>
1 parent 7cc2a30 commit f6da8d7

File tree

3 files changed

+11
-2
lines changed

3 files changed

+11
-2
lines changed

src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/upgrade/upgrade.component.html

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,8 @@ <h5>{{ version }}</h5>
5959
</div>
6060
<div cdsToggletipContent>
6161
<div class="cds--popover-scroll-container">
62-
<cd-health-checks [healthData]="healthData.health.checks"></cd-health-checks>
62+
<cd-health-checks [healthData]="healthData.health.checks"
63+
[legacyHealthChecks]="true"></cd-health-checks>
6364
</div>
6465
</div>
6566
</cds-toggletip>

src/pybind/mgr/dashboard/frontend/src/app/ceph/shared/health-checks/health-checks.component.html

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,11 @@
77
<li *ngFor="let check of healthData | keyvalue">
88
<span [ngStyle]="check.value.severity | healthColor"
99
[class.health-warn-description]="check.value.severity === 'HEALTH_WARN'">
10-
{{ check.key }}</span>: {{ check.value.summary.message }} <br>
10+
@if (legacyHealthChecks) {
11+
{{ check.value.type }}
12+
} @else {
13+
{{ check.key }}
14+
}
15+
</span>: {{ check.value.summary.message }} <br>
1116
</li>
1217
</ul>

src/pybind/mgr/dashboard/frontend/src/app/ceph/shared/health-checks/health-checks.component.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,9 @@ export class HealthChecksComponent {
1212
@Input()
1313
healthData: any;
1414

15+
@Input()
16+
legacyHealthChecks = false;
17+
1518
icons = Icons;
1619

1720
permissions: Permissions;

0 commit comments

Comments
 (0)