crimson/osd/osd_operations/snaptrim_event: using snap_trim_*_ret_t

Signed-off-by: Matan Breizman <[email protected]>

Author: Matan-B

src/crimson/osd/osd_operations/snaptrim_event.cc

@@ -60,7 +60,7 @@ CommonPGPipeline& SnapTrimEvent::client_pp()
   return pg->request_pg_pipeline;
 }
 
-SnapTrimEvent::snap_trim_ertr::future<seastar::stop_iteration>
+SnapTrimEvent::snap_trim_event_ret_t
 SnapTrimEvent::start()
 {
   ShardServices &shard_services = pg->get_shard_services();
@@ -167,7 +167,7 @@ SnapTrimEvent::start()
         });
       });
     });
-  }, [this](std::exception_ptr eptr) -> snap_trim_ertr::future<seastar::stop_iteration> {
+  }, [this](std::exception_ptr eptr) -> snap_trim_event_ret_t {
     logger().debug("{}: interrupted {}", *this, eptr);
     return crimson::ct_error::eagain::make();
   }, pg).finally([this] {
@@ -184,7 +184,7 @@ CommonPGPipeline& SnapTrimObjSubEvent::client_pp()
   return pg->request_pg_pipeline;
 }
 
-SnapTrimObjSubEvent::remove_or_update_iertr::future<>
+SnapTrimObjSubEvent::snap_trim_obj_subevent_ret_t
 SnapTrimObjSubEvent::remove_clone(
   ObjectContextRef obc,
   ObjectContextRef head_obc,
@@ -431,7 +431,7 @@ SnapTrimObjSubEvent::remove_or_update(
   });
 }
 
-SnapTrimObjSubEvent::remove_or_update_iertr::future<>
+SnapTrimObjSubEvent::snap_trim_obj_subevent_ret_t
 SnapTrimObjSubEvent::start()
 {
   return enter_stage<interruptor>(

src/crimson/osd/osd_operations/snaptrim_event.h

@@ -39,6 +39,10 @@ class SnapTrimEvent final : public PhasedOperationT<SnapTrimEvent> {
     crimson::ct_error::eagain>;
   using snap_trim_iertr = remove_or_update_iertr::extend<
     crimson::ct_error::eagain>;
+  using snap_trim_event_ret_t =
+    snap_trim_ertr::future<seastar::stop_iteration>;
+  using snap_trim_obj_subevent_ret_t =
+      remove_or_update_iertr::future<>;
 
   static constexpr OperationTypeCode type = OperationTypeCode::snaptrim_event;
 
@@ -53,12 +57,12 @@ class SnapTrimEvent final : public PhasedOperationT<SnapTrimEvent> {
 
   void print(std::ostream &) const final;
   void dump_detail(ceph::Formatter* f) const final;
-  snap_trim_ertr::future<seastar::stop_iteration> start();
+  snap_trim_event_ret_t start();
 
 private:
   CommonPGPipeline& client_pp();
 
-  SubOpBlocker<remove_or_update_iertr::future<>> subop_blocker;
+  SubOpBlocker<snap_trim_obj_subevent_ret_t> subop_blocker;
 
   // we don't need to synchronize with other instances of SnapTrimEvent;
   // it's here for the sake of op tracking.
@@ -108,6 +112,8 @@ class SnapTrimObjSubEvent : public PhasedOperationT<SnapTrimObjSubEvent> {
   using remove_or_update_iertr =
     crimson::interruptible::interruptible_errorator<
       IOInterruptCondition, remove_or_update_ertr>;
+  using snap_trim_obj_subevent_ret_t =
+      remove_or_update_iertr::future<>;
 
   static constexpr OperationTypeCode type =
     OperationTypeCode::snaptrimobj_subevent;
@@ -123,7 +129,7 @@ class SnapTrimObjSubEvent : public PhasedOperationT<SnapTrimObjSubEvent> {
 
   void print(std::ostream &) const final;
   void dump_detail(ceph::Formatter* f) const final;
-  remove_or_update_iertr::future<> start();
+  snap_trim_obj_subevent_ret_t start();
 
   CommonPGPipeline& client_pp();
 
@@ -132,7 +138,7 @@ class SnapTrimObjSubEvent : public PhasedOperationT<SnapTrimObjSubEvent> {
    * https://tracker.ceph.com/issues/63307 */
   object_stat_sum_t delta_stats;
 
-  remove_or_update_iertr::future<> remove_clone(
+  snap_trim_obj_subevent_ret_t remove_clone(
     ObjectContextRef obc,
     ObjectContextRef head_obc,
     ceph::os::Transaction& txn);