Skip to content

Commit f834e10

Browse files
committed
rgw: d3n: fix valgrind reported leak related to libaio ops
Fixes: https://tracker.ceph.com/issues/61661 The valgrind leak indication is a false positive in this case, it is because the libaio internal thread have not timed out yet when radosgw is terminated. ``` man aio_init ... aio_idle_time This field specifies the amount of time in seconds that a worker thread should wait for further requests before terminating, after having completed a previous request. The default value is 1. ... ``` for the sake of teuthology reducing the timeout waiting for 2 minutes for example like below would also prevent the leak report ``` ❯ env LD_LIBRARY_PATH=/mnt/nvme5n1p1/src-git/ceph--up--master-clang/build/lib/:$LD_LIBRARY_PATH PYTHONPATH=$PYTHONPATH:/mnt/nvme5n1p1/src-git/ceph--up--master-clang/build/lib/cython_modules/lib.3 RAGWEED_CONF=$(realpath ./ragweed.conf) RAGWEED_STAGES=prepare,check tox -- -v |& ccze -Aonolookups ; sleep 2m | pv -t ; pkill radosgw ``` Signed-off-by: Mark Kogan <[email protected]>
1 parent 26fda85 commit f834e10

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/rgw/driver/rados/rgw_d3n_datacache.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ void D3nDataCache::init(CephContext *_cct) {
103103
struct aioinit ainit{0};
104104
ainit.aio_threads = cct->_conf.get_val<int64_t>("rgw_d3n_libaio_aio_threads");
105105
ainit.aio_num = cct->_conf.get_val<int64_t>("rgw_d3n_libaio_aio_num");
106-
ainit.aio_idle_time = 120;
106+
ainit.aio_idle_time = 10;
107107
aio_init(&ainit);
108108
#endif
109109
}

0 commit comments

Comments
 (0)