Skip to content

Commit fa95da9

Browse files
authored
Merge pull request ceph#59925 from baum/NvmeofServiceSpec-service_id
pybind/mgr/orchestrator/module.py: NvmeofServiceSpec service_id
2 parents 5934c74 + e1612d0 commit fa95da9

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/pybind/mgr/orchestrator/module.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1560,7 +1560,7 @@ def _nvmeof_add(self,
15601560
raise OrchestratorValidationError('unrecognized command -i; -h or --help for usage')
15611561

15621562
spec = NvmeofServiceSpec(
1563-
service_id='nvmeof',
1563+
service_id=f'{pool}.{group}' if group else pool,
15641564
pool=pool,
15651565
group=group,
15661566
placement=PlacementSpec.from_string(placement),
@@ -1887,7 +1887,7 @@ def _apply_nvmeof(self,
18871887
raise OrchestratorValidationError('unrecognized command -i; -h or --help for usage')
18881888

18891889
spec = NvmeofServiceSpec(
1890-
service_id=f'{pool}.{group}',
1890+
service_id=f'{pool}.{group}' if group else pool,
18911891
pool=pool,
18921892
group=group,
18931893
placement=PlacementSpec.from_string(placement),

0 commit comments

Comments
 (0)