CephContext: acquire _fork_watchers_lock in notify_post_fork()

vshankar · vshankar · commit faef266331ae · 2023-11-09T17:16:57.000+05:30
The ceph::spin_unlock() seems incorrect here. Fixes: http://tracker.ceph.com/issues/63494 Signed-off-by: Venky Shankar <vshankar@redhat.com>
diff --git a/src/common/ceph_context.cc b/src/common/ceph_context.cc
@@ -1042,7 +1042,7 @@ void CephContext::notify_pre_fork()
 
 void CephContext::notify_post_fork()
 {
-  ceph::spin_unlock(&_fork_watchers_lock);
+  std::lock_guard lg(_fork_watchers_lock);
   for (auto &&t : _fork_watchers)
     t->handle_post_fork();
 }

Original file line number	Diff line number	Diff line change
`@@ -1042,7 +1042,7 @@ void CephContext::notify_pre_fork()`
`1042`	`1042`
`1043`	`1043`	`void CephContext::notify_post_fork()`
`1044`	`1044`	`{`
`1045`		`- ceph::spin_unlock(&_fork_watchers_lock);`
	`1045`	`+ std::lock_guard lg(_fork_watchers_lock);`
`1046`	`1046`	`for (auto &&t : _fork_watchers)`
`1047`	`1047`	`t->handle_post_fork();`
`1048`	`1048`	`}`