Skip to content

Commit 114a2f1

Browse files
committed
Revert "fix: oob when not set"
This reverts commit 2397dc6.
1 parent 77d8a19 commit 114a2f1

File tree

3 files changed

+2
-11
lines changed

3 files changed

+2
-11
lines changed

src/L2ArbitrumGovernor.sol

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -236,9 +236,6 @@ contract L2ArbitrumGovernor is
236236
uint256 calculatedQuorum =
237237
(pastTotalDelegatedVotes * quorumNumerator(blockNumber)) / quorumDenominator();
238238

239-
if (_minimumQuorumHistory.length() == 0) {
240-
return calculatedQuorum;
241-
}
242239
// get min and max quorum at the given block
243240
uint256 _minimumQuorum = _minimumQuorumHistory.getAtBlock(blockNumber);
244241
uint256 _maximumQuorum = _maximumQuorumHistory.getAtBlock(blockNumber);

test/signatures/L2ArbitrumGovernor

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,6 @@
2222
|------------------------------------------------------------------------------------+------------|
2323
| castVoteWithReasonAndParamsBySig(uint256,uint8,string,bytes,uint8,bytes32,bytes32) | 03420181 |
2424
|------------------------------------------------------------------------------------+------------|
25-
| dvpQuorumStartBlock() | 68c58a5f |
26-
|------------------------------------------------------------------------------------+------------|
2725
| execute(address[],uint256[],bytes[],bytes32) | 2656227d |
2826
|------------------------------------------------------------------------------------+------------|
2927
| getPastCirculatingSupply(uint256) | 6e462680 |
@@ -44,12 +42,8 @@
4442
|------------------------------------------------------------------------------------+------------|
4543
| maximumQuorum() | 13a2e752 |
4644
|------------------------------------------------------------------------------------+------------|
47-
| maximumQuorum(uint256) | acd092fa |
48-
|------------------------------------------------------------------------------------+------------|
4945
| minimumQuorum() | 8160f0b5 |
5046
|------------------------------------------------------------------------------------+------------|
51-
| minimumQuorum(uint256) | 5a029541 |
52-
|------------------------------------------------------------------------------------+------------|
5347
| name() | 06fdde03 |
5448
|------------------------------------------------------------------------------------+------------|
5549
| onERC1155BatchReceived(address,address,uint256[],uint256[],bytes) | bc197c81 |

test/storage/L2ArbitrumGovernor

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,9 +66,9 @@
6666
|-------------------------+---------------------------------------------------------------------------+------+--------+-------+-----------------------------------------------|
6767
| __gap | uint256[49] | 605 | 0 | 1568 | src/L2ArbitrumGovernor.sol:L2ArbitrumGovernor |
6868
|-------------------------+---------------------------------------------------------------------------+------+--------+-------+-----------------------------------------------|
69-
| _maximumQuorumHistory | struct CheckpointsUpgradeable.History | 654 | 0 | 32 | src/L2ArbitrumGovernor.sol:L2ArbitrumGovernor |
69+
| maximumQuorum | uint256 | 654 | 0 | 32 | src/L2ArbitrumGovernor.sol:L2ArbitrumGovernor |
7070
|-------------------------+---------------------------------------------------------------------------+------+--------+-------+-----------------------------------------------|
71-
| _minimumQuorumHistory | struct CheckpointsUpgradeable.History | 655 | 0 | 32 | src/L2ArbitrumGovernor.sol:L2ArbitrumGovernor |
71+
| minimumQuorum | uint256 | 655 | 0 | 32 | src/L2ArbitrumGovernor.sol:L2ArbitrumGovernor |
7272
|-------------------------+---------------------------------------------------------------------------+------+--------+-------+-----------------------------------------------|
7373
| proposers | mapping(uint256 => address) | 656 | 0 | 32 | src/L2ArbitrumGovernor.sol:L2ArbitrumGovernor |
7474
|-------------------------+---------------------------------------------------------------------------+------+--------+-------+-----------------------------------------------|

0 commit comments

Comments
 (0)