Skip to content

Commit ce941dd

Browse files
authored
Add onchain governor addresses to timelockRolesUpgrader test (#1)
* Add onchain governor addrs to timelockRolesUpgrader tests * Remove addr arguments
1 parent c89c349 commit ce941dd

File tree

2 files changed

+4
-8
lines changed

2 files changed

+4
-8
lines changed

script/DeployTimelockRolesUpgrader.s.sol

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,18 +9,15 @@ import {TimelockRolesUpgrader} from
99
import {SharedGovernorConstants} from "script/SharedGovernorConstants.sol";
1010

1111
contract DeployTimelockRolesUpgrader is BaseDeployer, SharedGovernorConstants {
12-
function run(address _newCoreGovernor, address _newTreasuryGovernor)
13-
public
14-
returns (TimelockRolesUpgrader timelockRolesUpgrader)
15-
{
12+
function run() public returns (TimelockRolesUpgrader timelockRolesUpgrader) {
1613
vm.startBroadcast();
1714
timelockRolesUpgrader = new TimelockRolesUpgrader(
1815
L2_CORE_GOVERNOR_TIMELOCK,
1916
L2_CORE_GOVERNOR,
20-
_newCoreGovernor,
17+
L2_CORE_GOVERNOR_ONCHAIN,
2118
L2_TREASURY_GOVERNOR_TIMELOCK,
2219
L2_TREASURY_GOVERNOR,
23-
_newTreasuryGovernor
20+
L2_TREASURY_GOVERNOR_ONCHAIN
2421
);
2522
vm.stopBroadcast();
2623
}

test/util/SetupNewGovernors.sol

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,8 +75,7 @@ abstract contract SetupNewGovernors is SharedGovernorConstants, Test {
7575
// Prepare the script to submit upgrade proposal
7676
submitUpgradeProposalScript = new SubmitUpgradeProposalScript();
7777
DeployTimelockRolesUpgrader deployTimelockRolesUpgrader = new DeployTimelockRolesUpgrader();
78-
timelockRolesUpgrader =
79-
deployTimelockRolesUpgrader.run(address(newCoreGovernor), address(newTreasuryGovernor));
78+
timelockRolesUpgrader = deployTimelockRolesUpgrader.run();
8079
}
8180
}
8281

0 commit comments

Comments
 (0)