Skip to content

Commit 416d547

Browse files
committed
moved testing_subpackage to vendor.testing
1 parent 42a3004 commit 416d547

File tree

6 files changed

+44
-27
lines changed

6 files changed

+44
-27
lines changed

extras/fileformats/extras/image/tests/test_image_converters.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,16 @@
1-
# import sys
21
import pytest
3-
from imageio.core.fetching import get_remote_file
42
from fileformats.image import Bitmap, Gif, Jpeg, Png, Tiff
3+
from imageio.core.fetching import get_remote_file
54

65

76
@pytest.fixture(scope="session")
87
def jpg() -> Jpeg:
9-
# imageio.imread("imageio:bricks.jpg")
108
return Jpeg(get_remote_file("images/bricks.jpg"))
119

1210

1311
@pytest.fixture(scope="session")
1412
def png() -> Png:
13+
1514
return Png(get_remote_file("images/chelsea.png"))
1615

1716

fileformats/core/identification.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,15 @@
2121
"multipart",
2222
"text",
2323
"video",
24+
"vendor.ms_excel",
25+
"vendor.ms_powerpoint",
26+
"vendor.ms_word",
27+
"vendor.openxmlformats_officedocument",
2428
]
2529
ALL_STANDARD_TYPE_REGISTRIES = IANA_MIME_TYPE_REGISTRIES + [
2630
"field",
2731
"testing",
28-
"testing_subpackage",
32+
"vendor.testing",
2933
]
3034

3135

fileformats/core/tests/test_mime.py

Lines changed: 20 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
from fileformats.core.identification import from_mime
33
from fileformats.generic import DirectoryOf, FileSet
44
from fileformats.testing import Classified, U, V
5-
from fileformats.testing_subpackage import Psi, SubpackageClassified, Theta, Zeta
5+
from fileformats.vendor.testing.testing import Psi, VendorClassified, Theta, Zeta
66
from fileformats.vendor.openxmlformats_officedocument.application import (
77
Wordprocessingml_Document,
88
)
@@ -24,40 +24,43 @@ def test_mimelike_roundtrip() -> None:
2424
assert reloaded is klass
2525

2626

27-
def test_subpackage_to_mime_roundtrip() -> None:
28-
assert Psi.mime_like == "testing-subpackage/psi"
29-
assert from_mime("testing-subpackage/psi") is Psi
27+
def test_vendor_to_mime_roundtrip() -> None:
28+
assert Psi.mime_like == "testing/vnd.testing.psi"
29+
assert from_mime("testing/vnd.testing.psi") is Psi
3030

3131

32-
def test_subpackage_to_mime_classified_rountrip() -> None:
32+
def test_vendor_to_mime_classified_rountrip() -> None:
3333
assert (
34-
SubpackageClassified[Zeta, Theta].mime_like
35-
== "testing-subpackage/theta..zeta+subpackage-classified"
34+
VendorClassified[Zeta, Theta].mime_like
35+
== "testing/[vnd.testing.theta..vnd.testing.zeta]+vnd.testing.vendor-classified"
3636
)
3737
assert (
38-
from_mime("testing-subpackage/theta..zeta+subpackage-classified")
39-
is SubpackageClassified[Zeta, Theta]
38+
from_mime(
39+
"testing/[vnd.testing.theta..vnd.testing.zeta]+vnd.testing.vendor-classified"
40+
)
41+
is VendorClassified[Zeta, Theta]
4042
)
4143

4244

43-
def test_subpackage_to_mime_parent_classified_rountrip() -> None:
45+
def test_vendor_to_mime_parent_classified_rountrip() -> None:
4446
assert (
45-
Classified[Zeta, Theta].mime_like == "testing-subpackage/theta..zeta+classified"
47+
Classified[Zeta, Theta].mime_like
48+
== "testing/[vnd.testing.theta..vnd.testing.zeta]+classified"
4649
)
4750
assert (
48-
from_mime("testing-subpackage/theta..zeta+classified")
51+
from_mime("testing/[vnd.testing.theta..vnd.testing.zeta]+classified")
4952
is Classified[Zeta, Theta]
5053
)
5154

5255

53-
def test_subpackage_to_mime_parent_classifiers_rountrip() -> None:
56+
def test_vendor_to_mime_parent_classifiers_rountrip() -> None:
5457
assert (
55-
SubpackageClassified[U, V].mime_like
56-
== "testing-subpackage/u..v+subpackage-classified"
58+
VendorClassified[U, V].mime_like
59+
== "testing/[u..v]+vnd.testing.vendor-classified"
5760
)
5861
assert (
59-
from_mime("testing-subpackage/u..v+subpackage-classified")
60-
is SubpackageClassified[U, V]
62+
from_mime("testing/[u..v]+vnd.testing.vendor-classified")
63+
is VendorClassified[U, V]
6164
)
6265

6366

fileformats/core/utils.py

Lines changed: 15 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import importlib
22
import inspect
3+
import itertools
34
import logging
45
import os
56
import pkgutil
@@ -11,6 +12,7 @@
1112
from types import ModuleType
1213

1314
import fileformats.core
15+
import fileformats.vendor
1416
from fileformats.core.exceptions import FormatDefinitionError
1517

1618
from .typing import FspathsInputType
@@ -22,7 +24,7 @@
2224
[
2325
"core",
2426
"testing",
25-
"testing_subpackage",
27+
"vendor.testing",
2628
"serialization",
2729
"archive",
2830
"document",
@@ -65,10 +67,19 @@ def subpackages(
6567
module
6668
all modules within the package
6769
"""
68-
for mod_info in pkgutil.iter_modules(
69-
fileformats.__path__, prefix=fileformats.__package__ + "."
70+
for mod_info in itertools.chain(
71+
pkgutil.iter_modules(
72+
fileformats.__path__, prefix=fileformats.__package__ + "."
73+
),
74+
pkgutil.iter_modules(
75+
fileformats.vendor.__path__,
76+
prefix=fileformats.vendor.__package__ + ".",
77+
),
7078
):
71-
if mod_info.name.split(".")[-1] in exclude:
79+
parts = mod_info.name.split(".")
80+
if parts[-1] in exclude or (
81+
parts[1] == "vendor" and ".".join(parts[:2]) in exclude
82+
):
7283
continue
7384
yield importlib.import_module(mod_info.name)
7485

fileformats/testing_subpackage/__init__.py renamed to fileformats/vendor/testing/testing.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
from fileformats.core.mixin import WithClassifiers
33

44

5-
class SubpackageClassified(WithClassifiers, DataType):
5+
class VendorClassified(WithClassifiers, DataType):
66
classifiers_attr_name = "classifiers"
77
classifiers = ()
88
allowed_classifiers = (Classifier,)
@@ -21,4 +21,4 @@ class Theta(Classifier):
2121
pass
2222

2323

24-
__all__ = ["SubpackageClassified", "Psi", "Zeta", "Theta", "__version__"]
24+
__all__ = ["VendorClassified", "Psi", "Zeta", "Theta", "__version__"]

0 commit comments

Comments
 (0)