Skip to content

Commit a03f51f

Browse files
authored
Merge pull request #3875 from deltachat/adb/issue-3874
avoid NPE in DecryptableUri
2 parents b110c1f + ef8d833 commit a03f51f

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

src/main/java/org/thoughtcrime/securesms/components/QuoteView.java

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -237,11 +237,13 @@ private void setQuoteAttachment(@NonNull GlideRequests glideRequests, @NonNull S
237237
MediaUtil.createVideoThumbnailIfNeeded(getContext(), slide.getUri(), slide.getThumbnailUri(), null);
238238
thumbnailUri = slide.getThumbnailUri();
239239
}
240-
glideRequests.load(new DecryptableUri(thumbnailUri))
241-
.centerCrop()
242-
.override(getContext().getResources().getDimensionPixelSize(R.dimen.quote_thumb_size))
243-
.diskCacheStrategy(DiskCacheStrategy.RESOURCE)
244-
.into(thumbnailView);
240+
if (thumbnailUri != null) {
241+
glideRequests.load(new DecryptableUri(thumbnailUri))
242+
.centerCrop()
243+
.override(getContext().getResources().getDimensionPixelSize(R.dimen.quote_thumb_size))
244+
.diskCacheStrategy(DiskCacheStrategy.RESOURCE)
245+
.into(thumbnailView);
246+
}
245247
}
246248
} else if(slide != null && slide.hasAudio()) {
247249
thumbnailView.setVisibility(GONE);

src/main/java/org/thoughtcrime/securesms/scribbles/UriGlideRenderer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ private GlideRequest<Bitmap> getBitmapGlideRequest(@NonNull Context context, boo
179179
.diskCacheStrategy(DiskCacheStrategy.NONE)
180180
.override(width, height)
181181
.centerInside()
182-
.load(decryptable ? new DecryptableStreamUriLoader.DecryptableUri(imageUri) : imageUri);
182+
.load(decryptable && imageUri!=null ? new DecryptableStreamUriLoader.DecryptableUri(imageUri) : imageUri);
183183
}
184184

185185
@Override

0 commit comments

Comments
 (0)