#39 Use real pre-delay offset for the IRs.

Author: Archie3d

Source/aeolus/engine.cpp

@@ -216,19 +216,15 @@ void EngineGlobal::loadIRs()
 {
     _irs.clear();
 
-    // This corresponds to the zero-delay segment of the
-    // convolver (see dsp/convolver.cpp) that we remove from
-    // the beginning of the IRs and use non-zero delay instead
-    // for better performance.
-    constexpr size_t startOffset = 4096;
+    // Here we offset the IRs predelay and use non-zero convolution instead.
 
     _irs.push_back({
         "York Guildhall Council Chamber",
         BinaryData::york_council_chamber_wav,
         BinaryData::york_council_chamber_wavSize,
         0.25f,
         false,
-        startOffset,
+        216,
         {}
     });
 
@@ -238,7 +234,7 @@ void EngineGlobal::loadIRs()
         BinaryData::st_laurentius_molenbeek_wavSize,
         0.8f,
         false,
-        startOffset,
+        15,
         {}
     });
 
@@ -248,7 +244,7 @@ void EngineGlobal::loadIRs()
         BinaryData::st_andrews_church_wavSize,
         1.0f,
         false,
-        startOffset,
+        1796,
         {}
     });
 
@@ -258,7 +254,7 @@ void EngineGlobal::loadIRs()
         BinaryData::st_georges_far_wavSize,
         1.0f,
         false,
-        startOffset,
+        1776,
         {}
     });
 
@@ -268,7 +264,7 @@ void EngineGlobal::loadIRs()
         BinaryData::lady_chapel_stalbans_wavSize,
         1.0f,
         false,
-        startOffset,
+        385,
         {}
     });
 
@@ -278,7 +274,7 @@ void EngineGlobal::loadIRs()
         BinaryData::_1st_baptist_nashville_balcony_wavSize,
         1.0f,
         false,
-        startOffset,
+        1764,
         {}
     });
 
@@ -288,7 +284,7 @@ void EngineGlobal::loadIRs()
         BinaryData::elveden_hall_suffolk_england_wavSize,
         0.1f,
         false,
-        0,
+        28,
         {}
     });
 
@@ -298,7 +294,7 @@ void EngineGlobal::loadIRs()
         BinaryData::r1_nuclear_reactor_hall_wavSize,
         0.4f,
         false,
-        startOffset,
+        1995,
         {}
     });
 
@@ -308,7 +304,7 @@ void EngineGlobal::loadIRs()
         BinaryData::york_uni_sportscentre_wavSize,
         0.4f,
         false,
-        startOffset,
+        1309,
         {}
     });
 
@@ -318,7 +314,7 @@ void EngineGlobal::loadIRs()
         BinaryData::york_minster_wavSize,
         0.3f,
         false,
-        startOffset,
+        3098,
         {}
     });
 
@@ -332,7 +328,8 @@ void EngineGlobal::loadIRs()
         std::unique_ptr<InputStream> stream = std::make_unique<MemoryInputStream>(ir.data, ir.size, false);
         std::unique_ptr<AudioFormatReader> reader{manager.createReaderFor(std::move(stream))};
         ir.waveform.setSize(reader->numChannels, (int)reader->lengthInSamples);
-        reader->read(&ir.waveform, 0, ir.waveform.getNumSamples(), (juce::int64)ir.startOffset, true, true);
+        const auto offset{ (juce::int64)ir.startOffset };
+        reader->read(&ir.waveform, 0, ir.waveform.getNumSamples() - offset, offset, true, true);
 
         ir.waveform.applyGain(ir.gain);