Preserve sequencer step when saving plugin's global state.

Author: Archie3d

Source/aeolus/division.cpp

@@ -189,8 +189,11 @@ int Division::getLinksCount() const noexcept
 void Division::enableLink(int i, bool ena)
 {
     jassert(isPositiveAndBelow(i, _linkedDivisions.size()));
-    _linkedDivisions[i].enabled = ena;
-    _engine.getSequencer()->setCurrentStepDirty();
+
+    if (_linkedDivisions[i].enabled != ena) {
+        _linkedDivisions[i].enabled = ena;
+        _engine.getSequencer()->setCurrentStepDirty();
+    }
 }
 
 bool Division::isLinkEnabled(int i)
@@ -207,10 +210,17 @@ Division::Link& Division::getLinkByIndex(int i)
 
 void Division::cancelAllLinks()
 {
-    for (auto& link : _linkedDivisions)
-        link.enabled = false;
+    bool changed{ false };
 
-    _engine.getSequencer()->setCurrentStepDirty();
+    for (auto& link : _linkedDivisions) {
+        if (link.enabled) {
+            changed = true;
+            link.enabled = false;
+        }
+    }
+
+    if (changed)
+        _engine.getSequencer()->setCurrentStepDirty();
 }
 
 void Division::clear()
@@ -252,9 +262,11 @@ void Division::enableStop(int i, bool ena)
 {
     jassert(isPositiveAndBelow(i, _stops.size()));
 
-    _stops[i].setEnabled(ena);
+    if (_stops[i].isEnabled() != ena) {
+        _stops[i].setEnabled(ena);
 
-    _engine.getSequencer()->setCurrentStepDirty();
+        _engine.getSequencer()->setCurrentStepDirty();
+    }
 }
 
 bool Division::isStopEnabled(int i) const
@@ -304,10 +316,12 @@ void Division::setTremulantEnabled(bool ena) noexcept
     if (!_hasTremulant)
         return;
 
-    _tremulantEnabled = ena;
-    _tremulantTargetLevel = _tremulantEnabled ? _tremulantMaxLevel : 0.0f;
+    if (_tremulantEnabled != ena) {
+        _tremulantEnabled = ena;
+        _tremulantTargetLevel = _tremulantEnabled ? _tremulantMaxLevel : 0.0f;
 
-    _engine.getSequencer()->setCurrentStepDirty();
+        _engine.getSequencer()->setCurrentStepDirty();
+    }
 }
 
 float Division::getTremulantLevel(bool update)

Source/aeolus/engine.cpp

@@ -672,9 +672,6 @@ void Engine::setPersistentState(const var& state)
         // Restore the sequencer
         _sequencer->setPersistentState(obj->getProperty("sequencer"));
 
-        // The divisions state may be different from the sequencer, so we mark it dirty
-        _sequencer->setCurrentStepDirty();
-
         // Restore the divisions after the sequencer (in case we are restoring
         // from a state that did not have a sequencer before).
         if (const auto* divisions = obj->getProperty("divisions").getArray()) {

Source/aeolus/sequencer.cpp

@@ -122,6 +122,7 @@ var Sequencer::getPersistentState() const
 
     sequencerObj->setProperty("steps", stepsArr);
     sequencerObj->setProperty("current_step", getCurrentStep());
+    sequencerObj->setProperty("dirty", _dirty);
 
     return var{sequencerObj};
 }
@@ -144,6 +145,11 @@ void Sequencer::setPersistentState(const var& v)
             // and should not go into the sequencer.
             setStep(currentStep, false);
         }
+
+        setCurrentStepDirty();
+
+        if (auto&& v = sequencerObj->getProperty("dirty"); v.isBool())
+            _dirty = (bool)v;
     }
 }