Skip to content

Commit 1b5e953

Browse files
committed
windows: add chromewebstore to UNIX_ONLY_PROVIDER_NAMES
CRX extraction on Windows needs either POSIX unzip (not present) or a bundled unzipper npm package (not currently bundled). The in-process CRX-header strip + tar -xf fallback I tried isn't working reliably on the Windows runners. Until someone bundles unzipper or a pure-JS extractor, treat chromewebstore like the other Unix-only providers — drop it from DEFAULT_PROVIDER_NAMES on Windows and let the conftest skip filter elide test_chromewebstoreprovider.py.
1 parent 81358ca commit 1b5e953

1 file changed

Lines changed: 13 additions & 1 deletion

File tree

abxpkg/windows_compat.py

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,20 @@
4040
# when ``IS_WINDOWS`` is true. ``scoop`` takes brew's place on Windows.
4141
# ``docker`` is excluded because its install handler writes a ``/bin/sh``
4242
# shim; the CLI itself works fine once installed outside abxpkg.
43+
# ``chromewebstore`` needs POSIX ``unzip`` (or a bundled ``unzipper``
44+
# npm dep) to unpack ``.crx`` files; neither is reliably available on
45+
# Windows runners, so disable until that's addressed.
4346
UNIX_ONLY_PROVIDER_NAMES: frozenset[str] = frozenset(
44-
{"apt", "brew", "nix", "bash", "ansible", "pyinfra", "docker"},
47+
{
48+
"apt",
49+
"brew",
50+
"nix",
51+
"bash",
52+
"ansible",
53+
"pyinfra",
54+
"docker",
55+
"chromewebstore",
56+
},
4557
)
4658

4759
# Mirrors the 7-tuple layout of :class:`pwd.struct_passwd` so Unix and

0 commit comments

Comments
 (0)