Commit 6885e3a
committed
Puppeteer abspath_handler: guard _refresh_symlink when bin_dir is None
Devin caught the parity bug I introduced: ``_refresh_symlink`` asserts
``bin_dir is not None``, but in global/unmanaged mode
(``install_root=None``) ``bin_dir`` is ``None`` and the ``except OSError``
doesn't catch the resulting ``AssertionError`` — crashing
``default_abspath_handler`` instead of returning the resolved path.
Add the same early-return guard ``PlaywrightProvider`` already has:
when ``bin_dir`` is ``None`` we return ``resolved`` directly without
attempting a shim refresh.1 parent 1788b18 commit 6885e3a
1 file changed
Lines changed: 6 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
430 | 430 | | |
431 | 431 | | |
432 | 432 | | |
433 | | - | |
434 | | - | |
| 433 | + | |
| 434 | + | |
| 435 | + | |
| 436 | + | |
| 437 | + | |
| 438 | + | |
435 | 439 | | |
436 | 440 | | |
437 | 441 | | |
| |||
0 commit comments