Skip to content

Commit 8acae71

Browse files
committed
playwright: drop --with-deps flag on Windows (unsupported; noisy no-op)
Playwright's --with-deps is a Linux apt-get-based dependency installer (and a macOS no-op). On Windows it's flat-out unsupported — Playwright prints a hard warning and ignores the flag. That warning pollutes our install log parser. Gate the flag on not IS_WINDOWS so the Windows install invocation stays clean.
1 parent d91336f commit 8acae71

1 file changed

Lines changed: 8 additions & 1 deletion

File tree

abxpkg/binprovider_playwright.py

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -605,7 +605,14 @@ def default_install_handler(
605605
**context,
606606
) -> str:
607607
install_args = list(install_args or self.get_install_args(bin_name))
608-
merged_args = ["--with-deps", *install_args]
608+
# ``--with-deps`` lets Playwright ``apt-get install`` the browser's
609+
# native sys-libs on Linux, is a no-op on macOS, and is flat-out
610+
# unsupported on Windows (Playwright prints a hard warning and
611+
# ignores the flag, but emitting it is noisy and confuses the
612+
# log-line parser). Gate it on platform.
613+
merged_args = (
614+
list(install_args) if IS_WINDOWS else ["--with-deps", *install_args]
615+
)
609616
if no_cache and "--force" not in merged_args:
610617
merged_args = ["--force", *merged_args]
611618

0 commit comments

Comments
 (0)