Skip to content

Commit 40b1d80

Browse files
committed
Added TODOs n stuff
1 parent 5798034 commit 40b1d80

File tree

6 files changed

+10
-4
lines changed

6 files changed

+10
-4
lines changed
Binary file not shown.
-183 Bytes
Binary file not shown.

src/main/java/dev/arctic/interactivemenuapi/animation/Animation.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77
import org.bukkit.scheduler.BukkitRunnable;
88
import org.bukkit.util.Vector;
99

10+
//TODO - implement Animations to be used in the Menu API and apply them to the elements and divisions automatically
11+
1012
/**
1113
* Represents an animation that can be applied to elements or divisions in the Interactive Menu API.
1214
*/

src/main/java/dev/arctic/interactivemenuapi/objects/Element.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@
1414

1515
import java.util.function.BiConsumer;
1616

17+
//TODO - Add methods to adjust the interaction entity sizes as part of the Builder
18+
1719
@Getter
1820
@Setter
1921
public abstract class Element implements IElement {
@@ -43,8 +45,8 @@ protected void initializeEntities() {
4345
this.textDisplayEntity = location.getWorld().spawn(location, TextDisplay.class, textDisplay -> textDisplay.setPersistent(false));
4446
}
4547

46-
public void updateLocation(Location divisionLocation) {
47-
Location newLocation = divisionLocation.clone().add(getAdjustedOffset(divisionLocation, offset, divisionLocation.getYaw()));
48+
public void updateLocation(Location startLocation) {
49+
Location newLocation = startLocation.clone().add(getAdjustedOffset(startLocation, offset, startLocation.getYaw()));
4850

4951
interactionEntity.teleport(newLocation);
5052
textDisplayEntity.teleport(newLocation);

src/main/java/dev/arctic/interactivemenuapi/objects/Menu.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,8 @@ public void cleanup() {
106106

107107
updateTask.cancel();
108108
cleanupTask.cancel();
109+
110+
MenuManager.removeMenu(this);
109111
}
110112

111113
public void addDivision(Division division) {

src/main/java/dev/arctic/interactivemenuapi/objects/elements/DisplayElement.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -131,8 +131,8 @@ public void setCurrentLocation(Location currentLocation) {
131131

132132

133133
@Override
134-
public void updateLocation(Location divisionLocation) {
135-
Location newLocation = divisionLocation.clone().add(getAdjustedOffset(divisionLocation, offset, divisionLocation.getYaw()));
134+
public void updateLocation(Location startLocation) {
135+
Location newLocation = startLocation.clone().add(getAdjustedOffset(startLocation, offset, startLocation.getYaw()));
136136

137137
interactionEntity.teleport(newLocation);
138138
displayEntity.teleport(newLocation.add(0,0.5,0));

0 commit comments

Comments
 (0)