checklist: added scrollbar for long lists

Author: tridge

MAVProxy/modules/lib/mp_checklist.py

@@ -65,7 +65,7 @@ class ChecklistFrame(wx.Frame):
 
     def __init__(self, state, title):
         self.state = state
-        wx.Frame.__init__(self, None, title=title, size=(600,600), style=wx.DEFAULT_FRAME_STYLE ^ wx.RESIZE_BORDER)
+        wx.Frame.__init__(self, None, title=title, size=(600,600), style=wx.DEFAULT_FRAME_STYLE)
 
         #use tabs for the individual checklists
         self.createLists()
@@ -77,7 +77,6 @@ def __init__(self, state, title):
 
         #add in the pipe from MAVProxy
         self.timer = wx.Timer(self)
-        #self.Bind(wx.EVT_TIMER, self.on_timer, self.timer)
         self.Bind(wx.EVT_TIMER, lambda evt, notebook=self.nb: self.on_timer(evt, notebook), self.timer)
         self.timer.Start(100)
 
@@ -137,34 +136,52 @@ def createWidgets(self):
         #create the panels for the tabs
 
         for name in self.lists.keys():
+            # Create the panel for this tab
             panel = wx.Panel(self.nb)
+            
+            # Create a scrolled window within the panel
+            scrolled_window = wx.ScrolledWindow(panel, wx.ID_ANY, style=wx.VSCROLL)
+            scrolled_window.SetScrollRate(0, 10)
+            
+            # Create a vertical box sizer for the scrolled window
             box = wx.BoxSizer(wx.VERTICAL)
-            panel.SetAutoLayout(True)
-            panel.SetSizer(box)
+            scrolled_window.SetSizer(box)
 
+            # Add each checkbox to the scrolled window
             for key in self.lists[name]:
-                CheckBox = wx.CheckBox(panel, wx.ID_ANY, key)
-                box.Add(CheckBox)
-
-            panel.Layout()
+                CheckBox = wx.CheckBox(scrolled_window, wx.ID_ANY, key)
+                box.Add(CheckBox, 0, wx.ALL, 5)
+
+            # Create a sizer for the panel and add the scrolled window to it
+            panel_sizer = wx.BoxSizer(wx.VERTICAL)
+            panel_sizer.Add(scrolled_window, 1, wx.EXPAND|wx.ALL, 0)
+            panel.SetSizer(panel_sizer)
+            
+            # Add the panel to the notebook
             self.nb.AddPage(panel, name)
 
     #Receive messages from MAVProxy and process them
     def on_timer(self, event, notebook):
         state = self.state
-        win = notebook.GetPage(notebook.GetSelection())
+        page = notebook.GetPage(notebook.GetSelection())
+        
         if state.close_event.wait(0.001):
             self.timer.Stop()
             self.Destroy()
             return
+        
         while state.child_pipe.poll():
             obj = state.child_pipe.recv()
             if isinstance(obj, CheckItem):
-                #go through each item in the current tab and (un)check as needed
-                #print(obj.name + ", " + str(obj.state))
-                for widget in win.GetChildren():
-                    if type(widget) is wx.CheckBox and widget.GetLabel() == obj.name:
-                        widget.SetValue(obj.state)
+                # Find the scrolled window which is the first child of the page
+                for child in page.GetChildren():
+                    if isinstance(child, wx.ScrolledWindow):
+                        scrolled_window = child
+                        # Go through each item in the current tab and (un)check as needed
+                        for widget in scrolled_window.GetChildren():
+                            if isinstance(widget, wx.CheckBox) and widget.GetLabel() == obj.name:
+                                widget.SetValue(obj.state)
+                        break
 
 
 if __name__ == "__main__":