Add # flake8: noqa directive to all failing files

Author: cclauss

.github/workflows/python-cleanliness.yml

@@ -16,10 +16,15 @@ jobs:
         with:
           submodules: 'recursive'
 
+      # Run flake8 but exclude third-party libraries
+      - run: pipx run flake8 --exclude=MAVProxy/modules/mavproxy_cesium,MAVProxy/modules/lib
+      # Once this has been running for a while, we can:
+      # - delete the lines below
+      # - delete scripts/run_flake8.py
+      # - remove all instances of AP_FLAKE8_CLEAN (git grep AP_FLAKE8_CLEAN)
+
       - name: Install dependencies
-        run: |
-          python -m pip install -U flake8
+        run: python -m pip install --upgrade flake8
 
       - name: Check Python with Flake8
-        run: |
-            scripts/run_flake8.py MAVProxy
+        run: scripts/run_flake8.py MAVProxy

MAVProxy/modules/mavproxy_DGPS.py

@@ -3,6 +3,8 @@
 support for a GCS attached DGPS system
 '''
 
+# flake8: noqa
+
 import socket, errno
 from pymavlink import mavutil
 from MAVProxy.modules.lib import mp_module

MAVProxy/modules/mavproxy_GPSInject.py

@@ -3,6 +3,8 @@
 primarily used to inject uBlox AssistNow data
 """
 
+# flake8: noqa
+
 import random
 import time
 import os

MAVProxy/modules/mavproxy_GPSInput.py

@@ -3,6 +3,8 @@
 support for GPS_INPUT message
 '''
 
+# flake8: noqa
+
 import socket, errno
 import json
 from pymavlink import mavutil

MAVProxy/modules/mavproxy_HIL.py

@@ -7,6 +7,8 @@
 This interfaces to Tools/autotest/jsbsim/runsim.py to run the JSBSim flight simulator
 '''
 
+# flake8: noqa
+
 import sys, os, time, socket, errno, struct, math
 from math import degrees, radians
 from MAVProxy.modules.lib import mp_module

MAVProxy/modules/mavproxy_OpenDroneID.py

@@ -2,6 +2,8 @@
 Support for OpenDroneID
 '''
 
+# flake8: noqa
+
 from MAVProxy.modules.lib import mp_module
 from MAVProxy.modules.lib import mp_settings
 from pymavlink import mavutil

MAVProxy/modules/mavproxy_SIYI/__init__.py

@@ -7,6 +7,8 @@
   circle hottest area?
 '''
 
+# flake8: noqa
+
 from MAVProxy.modules.lib import mp_module
 from MAVProxy.modules.lib import mp_settings
 from MAVProxy.modules.lib.mp_settings import MPSetting

MAVProxy/modules/mavproxy_SIYI/camera_view.py

@@ -1,5 +1,7 @@
 #!/usr/bin/env python3
 
+# flake8: noqa
+
 from threading import Thread
 import cv2
 

MAVProxy/modules/mavproxy_SIYI/raw_thermal.py

@@ -1,5 +1,7 @@
 #!/usr/bin/env python3
 
+# flake8: noqa
+
 from threading import Thread
 import cv2
 import os

MAVProxy/modules/mavproxy_SIYI/tools/playback.py

@@ -3,6 +3,8 @@
 playback videos with temperature data
 '''
 
+# flake8: noqa
+
 from MAVProxy.modules.lib.mp_image import MPImage
 from MAVProxy.modules.lib.mp_image import MPImageFrameCounter
 from MAVProxy.modules.lib.mp_image import MPImageOSD_HorizonLine