IMPROVEMENT: Make windows look the same as linux

Use white backgrounds in readonly comboboxes

Author: amilcarlucas

MethodicConfigurator/frontend_tkinter_base.py

@@ -314,14 +314,11 @@ def __init__(self, *args, **kwargs):
         self.tag_configure("h1", font=h1_font, spacing3=default_size)
 
 
-def get_font_family(widget: tk.Widget) -> str:
+def get_widget_font(widget: tk.Widget) -> dict:
     style = ttk.Style()
-    widget_style = widget.cget("style")  # Get the style used by the widget
-    font_descriptions = style.lookup(widget_style, 'font')
-    if font_descriptions:
-        font_family = font_descriptions[0]  # Font description is a tuple where the first element is the family
-        return font_family
-    return "Font family not found"
+    widget_style = widget.cget('style')  # Get the style used by the widget
+    font_name = style.lookup(widget_style, 'font')
+    return tkFont.nametofont(font_name).config()
 
 
 class BaseWindow:

MethodicConfigurator/frontend_tkinter_parameter_editor.py

@@ -34,7 +34,7 @@
 from MethodicConfigurator.frontend_tkinter_base import ProgressWindow
 from MethodicConfigurator.frontend_tkinter_base import BaseWindow
 from MethodicConfigurator.frontend_tkinter_base import RichText
-from MethodicConfigurator.frontend_tkinter_base import get_font_family
+from MethodicConfigurator.frontend_tkinter_base import get_widget_font
 
 from MethodicConfigurator.frontend_tkinter_directory_selection import VehicleDirectorySelectionWidgets
 
@@ -194,6 +194,11 @@ def __init__(self, current_file: str, flight_controller: FlightController,
         # Bind the close_connection_and_quit function to the window close event
         self.root.protocol("WM_DELETE_WINDOW", self.close_connection_and_quit)
 
+        style = ttk.Style()
+        style.map('readonly.TCombobox', fieldbackground=[('readonly', 'white')])
+        style.map('readonly.TCombobox', selectbackground=[('readonly', 'white')])
+        style.map('readonly.TCombobox', selectforeground=[('readonly', 'black')])
+
         self.__create_conf_widgets(version)
 
         # Create a DocumentationFrame object for the Documentation Content
@@ -238,11 +243,11 @@ def __create_conf_widgets(self, version: str):
                                                           "files in the selected vehicle directory\nIt will automatically "
                                                           "advance to the next file once the current file is uploaded to the "
                                                           "fight controller",
-                                                          state='readonly', width=45)
+                                                          state='readonly', width=45, style='readonly.TCombobox')
         self.file_selection_combobox.bind("<<ComboboxSelected>>", self.on_param_file_combobox_change)
         self.file_selection_combobox.pack(side=tk.TOP, anchor=tk.NW, pady=(4, 0))
 
-        self.legend_frame(config_subframe, get_font_family(file_selection_label))
+        self.legend_frame(config_subframe, get_widget_font(file_selection_label)['family'])
 
         image_label = BaseWindow.put_image_in_label(config_frame, LocalFilesystem.application_logo_filepath())
         image_label.pack(side=tk.RIGHT, anchor=tk.NE, padx=(4, 4), pady=(4, 0))

MethodicConfigurator/frontend_tkinter_parameter_editor_table.py

@@ -21,6 +21,8 @@
 #from logging import error as logging_error
 from logging import critical as logging_critical
 
+from platform import system as platform_system
+
 #from MethodicConfigurator.backend_filesystem import LocalFilesystem
 from MethodicConfigurator.backend_filesystem import is_within_tolerance
 
@@ -29,7 +31,7 @@
 from MethodicConfigurator.frontend_tkinter_base import show_tooltip
 #from MethodicConfigurator.frontend_tkinter_base import AutoResizeCombobox
 from MethodicConfigurator.frontend_tkinter_base import ScrollFrame
-from MethodicConfigurator.frontend_tkinter_base import get_font_family
+from MethodicConfigurator.frontend_tkinter_base import get_widget_font
 
 from MethodicConfigurator.frontend_tkinter_connection_selection import PairTupleCombobox
 
@@ -253,10 +255,12 @@ def __create_new_value_entry(self, param_name, param,  # pylint: disable=too-man
            value_str in param_metadata['values']:
             selected_value = param_metadata['values'].get(value_str, None)
             new_value_entry = PairTupleCombobox(self.view_port, param_metadata['values'],
-                                                value_str, param_name)
+                                                value_str, param_name,
+                                                style='TCombobox' if present_as_forced else 'readonly.TCombobox')
             new_value_entry.set(selected_value)
-            new_value_entry.config(state='readonly', width=9, font=(get_font_family(new_value_entry), 9))
-            new_value_entry.config(background='white')  # does not work when done together with state='readonly'
+            font = get_widget_font(new_value_entry)
+            font['size'] -= 2 if platform_system() == 'Windows' else 1
+            new_value_entry.config(state='readonly', width=9, font=(font['family'], font['size']))
         else:
             new_value_entry = ttk.Entry(self.view_port, width=10, justify=tk.RIGHT)
             ParameterEditorTable.__update_new_value_entry_text(new_value_entry, param.value, param_default)