Skip to content

Commit 22cc504

Browse files
committed
fix(windows build): Disable SLSA until they (upstream) pin all their actions by SHA
Error: The action slsa-framework/slsa-github-generator/.github/actions/detect-workflow-js@main is not allowed in ArduPilot/MethodicConfigurator because all actions must be pinned to a full-length commit SHA.
1 parent 724cfa9 commit 22cc504

File tree

1 file changed

+13
-12
lines changed

1 file changed

+13
-12
lines changed

.github/workflows/windows_build.yml

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -122,21 +122,22 @@ jobs:
122122
retention-days: 7
123123

124124
# Generate SLSA provenance using the official generic workflow
125-
provenance:
126-
needs: [build]
127-
permissions:
128-
actions: read # To read the workflow path
129-
id-token: write # To sign the provenance
130-
contents: write # To add assets to a release
131-
uses: slsa-framework/slsa-github-generator/.github/workflows/generator_generic_slsa3.yml@4876e96b8268fd8b7b8d8574718d06c0d0426d40 # latest commit
132-
with:
133-
base64-subjects: "${{ needs.build.outputs.hashes }}"
134-
upload-assets: ${{ startsWith(github.ref, 'refs/tags/v') }} # Only upload to releases for v* tags
135-
continue-on-error: false # Explicit error handling - fail fast for security issues
125+
# provenance:
126+
# needs: [build]
127+
# permissions:
128+
# actions: read # To read the workflow path
129+
# id-token: write # To sign the provenance
130+
# contents: write # To add assets to a release
131+
# uses: slsa-framework/slsa-github-generator/.github/workflows/generator_generic_slsa3.yml@4876e96b8268fd8b7b8d8574718d06c0d0426d40 # latest commit
132+
# with:
133+
# base64-subjects: "${{ needs.build.outputs.hashes }}"
134+
# upload-assets: ${{ startsWith(github.ref, 'refs/tags/v') }} # Only upload to releases for v* tags
135+
# continue-on-error: false # Explicit error handling - fail fast for security issues
136136

137137
# Release job that depends on provenance generation
138138
release:
139-
needs: [build, provenance]
139+
# needs: [build, provenance]
140+
needs: [build]
140141
runs-on: windows-latest
141142
if: startsWith(github.ref, 'refs/tags/v') || github.ref == format('refs/heads/{0}', github.event.repository.default_branch)
142143
permissions:

0 commit comments

Comments
 (0)