Skip to content

Commit 2aa3691

Browse files
committed
Fix ruff PERF203 by moving try/except outside loop
1 parent e97dc69 commit 2aa3691

File tree

1 file changed

+6
-7
lines changed

1 file changed

+6
-7
lines changed

ardupilot_methodic_configurator/frontend_tkinter_parameter_editor_table.py

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -846,22 +846,21 @@ def update_add_suggested_button_state() -> None:
846846
def on_add_suggested_parameters() -> None:
847847
filtered = get_filtered_parameter_names()
848848
added_any = False
849-
850-
851-
852-
for param_name in filtered:
853-
try:
849+
try:
850+
for param_name in filtered:
854851
if self.parameter_editor.add_parameter_to_current_file(param_name):
855852
added_any = True
856-
except (InvalidParameterNameError, OperationNotPossibleError):
857-
continue
853+
except (InvalidParameterNameError, OperationNotPossibleError):
854+
# Ignore invalid parameters and continue gracefully
855+
pass
858856

859857
if added_any:
860858
self._pending_scroll_to_bottom = True
861859
self.parameter_editor_window.repopulate_parameter_table()
862860

863861
add_parameter_window.root.destroy()
864862

863+
865864
add_suggested_button.configure(command=on_add_suggested_parameters)
866865

867866
# --- Update button state while typing

0 commit comments

Comments
 (0)