fix(program settings): Make it more robust

Author: amilcarlucas

ardupilot_methodic_configurator/backend_filesystem_program_settings.py

@@ -502,6 +502,9 @@ def store_connection(connection_string: str) -> None:
 
         settings = ProgramSettings._get_settings_as_dict()
         history = settings.get("connection_history", [])
+        if not isinstance(history, list):
+            logging_error("The ProgramSetting connection_history was not a list")
+            history = []
 
         if connection_string in history:
             history.remove(connection_string)

tests/test_backend_filesystem_program_settings.py

@@ -403,7 +403,7 @@ def test_user_can_load_existing_settings_file(self, mock_user_config, sample_pro
         expected_result["annotate_docs_into_param_files"] = False  # Added by default
         expected_result["gui_complexity"] = "simple"  # Added by default
         expected_result["motor_test"] = {"duration": 2, "throttle_pct": 10}  # Added by default
-        expected_result["connection_history"] = []  # Added for port connection string to save
+        expected_result["connection_history"] = []  # Added by default
         expected_result["display_usage_popup"]["component_editor_validation"] = True  # Added by default
         expected_result["display_usage_popup"]["workflow_explanation"] = True  # Added by default
         expected_result["display_usage_popup"]["bitmask_parameter_editor"] = True  # Added by default